1208594 - 3,900 instances of "NS_ENSURE_TRUE(aSelection->RangeCount()) failed" and subsequent warnings during linux64 debug testing

Status: RESOLVED INCOMPLETE

(Core :: DOM: Editor, defect)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #1184289 +++

Combined these make up the #1 most verbose set of warnings. The chain of warnings:

[NNNNN] WARNING: NS_ENSURE_TRUE(aSelection->RangeCount()) failed: file editor/libeditor/nsEditor.cpp, line 3746
[NNNNN] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file editor/libeditor/nsEditor.cpp, line 3725
[NNNNN] WARNING: NS_ENSURE_SUCCESS(res, res) failed with result 0x80004005: file editor/libeditor/nsHTMLEditRules.cpp, line 8097

Note 0x80004005 is NS_ERROR_FAILURE.

Individual details:

> 1259 [NNNNN] WARNING: NS_ENSURE_TRUE(aSelection->RangeCount()) failed: file editor/libeditor/nsEditor.cpp, line 3746

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm52-tests1-linux64-build6.txt:335
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm120-tests1-linux64-build7.txt:271
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm118-tests1-linux64-build14.txt:97
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm53-tests1-linux64-build33.txt:86
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm113-tests1-linux64-build10.txt:73
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm116-tests1-linux64-build34.txt:57
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build9.txt:48
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm67-tests1-linux64-build6.txt:46
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm54-tests1-linux64-build18.txt:46
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-2-bm68-tests1-linux64-build18.txt:34
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm53-tests1-linux64-build43.txt:32
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm117-tests1-linux64-build5.txt:26
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm67-tests1-linux64-build2.txt:24
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm123-tests1-linux64-build26.txt:23
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm53-tests1-linux64-build31.txt:19
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm54-tests1-linux64-build30.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm54-tests1-linux64-build25.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm54-tests1-linux64-build7.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm53-tests1-linux64-build9.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm121-tests1-linux64-build15.txt:3
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-4-bm51-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm121-tests1-linux64-build9.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-7-bm123-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-3-bm54-tests1-linux64-build39.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-5-bm51-tests1-linux64-build3.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm121-tests1-linux64-build7.txt:1

It shows up in 393 tests. A few of the most prevalent:

> 256 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-2.html
> 94 - file:///builds/slave/test/build/tests/reftest/tests/editor/libeditor/crashtests/759748.html
> 74 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-1.html
> 60 - layout/base/tests/test_reftests_with_caret.html
> 21 - dom/html/test/test_bug446483.html
> 18 - editor/libeditor/tests/test_bug611182.html
> 12 - file:///builds/slave/test/build/tests/reftest/tests/editor/reftests/824080-4.html
> 10 - editor/libeditor/tests/test_bug455992.html
> 8 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/613433-1.html
> 8 - dom/browser-element/mochitest/test_browserElement_inproc_CopyPaste.html


> 1259 [NNNNN] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file editor/libeditor/nsEditor.cpp, line 3725

This warning [2] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm52-tests1-linux64-build6.txt:335
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm120-tests1-linux64-build7.txt:271
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm118-tests1-linux64-build14.txt:97
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm53-tests1-linux64-build33.txt:86
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm113-tests1-linux64-build10.txt:73
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm116-tests1-linux64-build34.txt:57
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build9.txt:48
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm67-tests1-linux64-build6.txt:46
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm54-tests1-linux64-build18.txt:46
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-2-bm68-tests1-linux64-build18.txt:34
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm53-tests1-linux64-build43.txt:32
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm117-tests1-linux64-build5.txt:26
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm67-tests1-linux64-build2.txt:24
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm123-tests1-linux64-build26.txt:23
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm53-tests1-linux64-build31.txt:19
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm54-tests1-linux64-build30.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm54-tests1-linux64-build25.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm54-tests1-linux64-build7.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm53-tests1-linux64-build9.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm121-tests1-linux64-build15.txt:3
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-4-bm51-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm121-tests1-linux64-build9.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-7-bm123-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-3-bm54-tests1-linux64-build39.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-5-bm51-tests1-linux64-build3.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm121-tests1-linux64-build7.txt:1

It shows up in 393 tests. A few of the most prevalent:

> 256 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-2.html
> 94 - file:///builds/slave/test/build/tests/reftest/tests/editor/libeditor/crashtests/759748.html
> 74 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-1.html
> 60 - layout/base/tests/test_reftests_with_caret.html
> 21 - dom/html/test/test_bug446483.html
> 18 - editor/libeditor/tests/test_bug611182.html
> 12 - file:///builds/slave/test/build/tests/reftest/tests/editor/reftests/824080-4.html
> 10 - editor/libeditor/tests/test_bug455992.html
> 8 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/613433-1.html
> 8 - dom/browser-element/mochitest/test_browserElement_inproc_CopyPaste.html


> 1257 [NNNNN] WARNING: NS_ENSURE_SUCCESS(res, res) failed with result 0x80004005: file editor/libeditor/nsHTMLEditRules.cpp, line 8097

This warning [3] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm52-tests1-linux64-build6.txt:334
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm120-tests1-linux64-build7.txt:270
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm118-tests1-linux64-build14.txt:97
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm53-tests1-linux64-build33.txt:86
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm113-tests1-linux64-build10.txt:73
> mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm116-tests1-linux64-build34.txt:57
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build9.txt:48
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm67-tests1-linux64-build6.txt:46
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm54-tests1-linux64-build18.txt:46
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-2-bm68-tests1-linux64-build18.txt:34
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm53-tests1-linux64-build43.txt:32
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm117-tests1-linux64-build5.txt:26
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm67-tests1-linux64-build2.txt:24
> mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm123-tests1-linux64-build26.txt:23
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm53-tests1-linux64-build31.txt:19
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm54-tests1-linux64-build30.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm54-tests1-linux64-build25.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm54-tests1-linux64-build7.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm53-tests1-linux64-build9.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm121-tests1-linux64-build15.txt:3
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-4-bm51-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm121-tests1-linux64-build9.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-7-bm123-tests1-linux64-build2.txt:2
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-3-bm54-tests1-linux64-build39.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-5-bm51-tests1-linux64-build3.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm121-tests1-linux64-build7.txt:1

It shows up in 392 tests. A few of the most prevalent:

> 256 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-2.html
> 94 - file:///builds/slave/test/build/tests/reftest/tests/editor/libeditor/crashtests/759748.html
> 74 - file:///builds/slave/test/build/tests/reftest/tests/dom/base/crashtests/561981-1.html
> 60 - layout/base/tests/test_reftests_with_caret.html
> 21 - dom/html/test/test_bug446483.html
> 18 - editor/libeditor/tests/test_bug611182.html
> 12 - file:///builds/slave/test/build/tests/reftest/tests/editor/reftests/824080-4.html
> 10 - editor/libeditor/tests/test_bug455992.html
> 8 - file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/bugs/613433-1.html
> 8 - dom/browser-element/mochitest/test_browserElement_inproc_CopyPaste.html


[1] https://hg.mozilla.org/mozilla-central/annotate/5abe3c4deab9/editor/libeditor/nsEditor.cpp#l3746
[2] https://hg.mozilla.org/mozilla-central/annotate/5abe3c4deab9/editor/libeditor/nsEditor.cpp#l3725
[3] https://hg.mozilla.org/mozilla-central/annotate/5abe3c4deab9/editor/libeditor/nsHTMLEditRules.cpp#l8097

Comment 1

[Eric Rahm [:erahm]]

Masayuki did a pretty big editor refactoring in bug 1260651, I'm not seeing these specific warnings anymore. I'll refile new ones for the relocated warnings if appropriate.