Closed
Bug 1208607
Opened 9 years ago
Closed 9 years ago
Add 'lo' to Fennec all-locales for single-locale builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
People
(Reporter: gueroJeff, Unassigned)
References
Details
Attachments
(1 file)
505 bytes,
patch
|
Pike
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Please add Laos (lo) locale to mozilla-aurora/mobile/android/locales/all-locales to start fennec single-locale builds in Aurora and add Fennec to the lo team's dashboard.
Attachment #8666169 -
Flags: review?(l10n)
Attachment #8666169 -
Flags: approval-mozilla-aurora?
Comment 1•9 years ago
|
||
Comment on attachment 8666169 [details] [diff] [review] add-lo-all-locales.patch Review of attachment 8666169 [details] [diff] [review]: ----------------------------------------------------------------- There's no repository as of yet in https://hg.mozilla.org/releases/l10n/mozilla-aurora/, do you have a bug on file for that? Clearing flags for now.
Attachment #8666169 -
Flags: review?(l10n)
Attachment #8666169 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8666169 [details] [diff] [review] add-lo-all-locales.patch We've got the Lao repos up now. Sorry for jumping the gun earlier, I had forgotten we didn't actually have those repos yet. Approval Request Comment [Feature/regressing bug #]:1213064 [User impact if declined]:No testing for Lao localizers. [Describe test coverage new/current, TreeHerder]: [Risks and why]: Little to none [String/UUID change made/needed]:N/A
Attachment #8666169 -
Flags: review?(l10n)
Attachment #8666169 -
Flags: approval-mozilla-aurora?
Comment 3•9 years ago
|
||
Does this need to land in 44 as well? Or did it land already in another bug?
Flags: needinfo?(jbeatty)
Reporter | ||
Comment 4•9 years ago
|
||
No, this should only land on mozilla-aurora.
Flags: needinfo?(jbeatty)
Comment 5•9 years ago
|
||
OK after talking a bit on irc, it sounds like locale config issues get reverted on each merge day. So that's how we preserve locale build config changes from one Aurora version to the next and we don't put these changes on Nightly. As an example here is where that happened on our last merge day: https://hg.mozilla.org/releases/mozilla-aurora/rev/7f2f0fb041b1 Good to know!
Comment 6•9 years ago
|
||
Comment on attachment 8666169 [details] [diff] [review] add-lo-all-locales.patch Approved for uplift to aurora only; simple build config change for locales.
Attachment #8666169 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Updated•9 years ago
|
Whiteboard: [checkin-needed-aurora]
Comment 7•9 years ago
|
||
still need review from pike (l10n@mozilla.com) or ?
Updated•9 years ago
|
Flags: needinfo?(l10n)
Flags: needinfo?(jbeatty)
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(jbeatty)
Comment 8•9 years ago
|
||
liz, as just info, this is still pending, so not sure what do with the approval
Flags: needinfo?(lhenry)
Comment 9•9 years ago
|
||
Pike or flod.... does this still need review from your team?
Flags: needinfo?(lhenry) → needinfo?(francesco.lodolo)
Comment 10•9 years ago
|
||
I'm not sure what the flag fest is good for here. Issue at hand: http://hg.mozilla.org/releases/l10n/mozilla-aurora/lo/ and http://hg.mozilla.org/releases/l10n/mozilla-beta/lo/ (and release) are unrelated repos in the hg sense, due to a mistake on the first push. Possible resolutions: - redo the beta/aurora repos. Requires dashboard db work, and a quick downtime on my poller. Not sure what it does the hg poller on releng side - force-merge both repos, which is ugly, too
Flags: needinfo?(l10n)
Flags: needinfo?(francesco.lodolo)
Comment 11•9 years ago
|
||
clearing checkin-needed to remove it from our checkin-needed query till we have a solution for this bug. Please add this again when this bug/patch is ready for checkin, thanks!
Whiteboard: [checkin-needed-aurora]
Comment 12•9 years ago
|
||
Axel, I'm trying to figure out who is responsible for doing this work, and whether it needs to happen before we release 43 beta. Is this something you're working on? Do you need help, information, discussion, or resources from someone else? Let me know if there is anything I can do.
Comment 13•9 years ago
|
||
Comment on attachment 8666169 [details] [diff] [review] add-lo-all-locales.patch Review of attachment 8666169 [details] [diff] [review]: ----------------------------------------------------------------- r=me, sorry for the lag. The repo mishaps are now resolved, and the release and beta repos have the aurora history of now after I just pushed. This is now ready to land and go.
Attachment #8666169 -
Flags: review?(l10n) → review+
Updated•9 years ago
|
status-firefox43:
--- → affected
Keywords: checkin-needed
Reporter | ||
Comment 14•9 years ago
|
||
This should only land in mozilla-aurora, making it affect 44, but not 43.
Comment 15•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/22939c8dc3c4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
affected → ---
status-firefox44:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Comment 16•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/22939c8dc3c4
status-b2g-v2.5:
--- → fixed
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•