Add 'lo' to Fennec all-locales for single-locale builds

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gueroJeff, Unassigned)

Tracking

43 Branch
All
Android
Points:
---

Firefox Tracking Flags

(firefox44 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8666169 [details] [diff] [review]
add-lo-all-locales.patch

Please add Laos (lo) locale to mozilla-aurora/mobile/android/locales/all-locales to start fennec single-locale builds in Aurora and add Fennec to the lo team's dashboard.
Attachment #8666169 - Flags: review?(l10n)
Attachment #8666169 - Flags: approval-mozilla-aurora?

Comment 1

3 years ago
Comment on attachment 8666169 [details] [diff] [review]
add-lo-all-locales.patch

Review of attachment 8666169 [details] [diff] [review]:
-----------------------------------------------------------------

There's no repository as of yet in https://hg.mozilla.org/releases/l10n/mozilla-aurora/, do you have a bug on file for that?

Clearing flags for now.
Attachment #8666169 - Flags: review?(l10n)
Attachment #8666169 - Flags: approval-mozilla-aurora?
(Reporter)

Comment 2

3 years ago
Comment on attachment 8666169 [details] [diff] [review]
add-lo-all-locales.patch

We've got the Lao repos up now. Sorry for jumping the gun earlier, I had forgotten we didn't actually have those repos yet.

Approval Request Comment
[Feature/regressing bug #]:1213064
[User impact if declined]:No testing for Lao localizers.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Little to none
[String/UUID change made/needed]:N/A
Attachment #8666169 - Flags: review?(l10n)
Attachment #8666169 - Flags: approval-mozilla-aurora?
Does this need to land in 44 as well? Or did it land already in another bug?
Flags: needinfo?(jbeatty)
(Reporter)

Comment 4

3 years ago
No, this should only land on mozilla-aurora.
Flags: needinfo?(jbeatty)
OK after talking a bit on irc, it sounds like locale config issues get reverted on each merge day. So that's how we preserve locale build config changes from one Aurora version to the next and we don't put these changes on Nightly. As an example here is where that happened on our last merge day: https://hg.mozilla.org/releases/mozilla-aurora/rev/7f2f0fb041b1   

Good to know!
Comment on attachment 8666169 [details] [diff] [review]
add-lo-all-locales.patch

Approved for uplift to aurora only; simple build config change for locales.
Attachment #8666169 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Updated

3 years ago
Whiteboard: [checkin-needed-aurora]
still need review from pike (l10n@mozilla.com) or ?

Updated

3 years ago
Flags: needinfo?(l10n)
Flags: needinfo?(jbeatty)
(Reporter)

Updated

3 years ago
Flags: needinfo?(jbeatty)
liz, as just info, this is still pending, so not sure what do with the approval
Flags: needinfo?(lhenry)
Pike or flod.... does this still need review from your team?
Flags: needinfo?(lhenry) → needinfo?(francesco.lodolo)

Comment 10

3 years ago
I'm not sure what the flag fest is good for here.

Issue at hand:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/lo/ and
http://hg.mozilla.org/releases/l10n/mozilla-beta/lo/ (and release) are unrelated repos in the hg sense, due to a mistake on the first push.

Possible resolutions:

- redo the beta/aurora repos. Requires dashboard db work, and a quick downtime on my poller. Not sure what it does the hg poller on releng side
- force-merge both repos, which is ugly, too
Flags: needinfo?(l10n)
Flags: needinfo?(francesco.lodolo)
clearing checkin-needed to remove it from our checkin-needed query till we have a solution for this bug. Please add this again when this bug/patch is ready for checkin, thanks!
Whiteboard: [checkin-needed-aurora]
Axel, I'm trying to figure out who is responsible for doing this work, and whether it needs to happen before we release 43 beta. Is this something you're working on? 
Do you need help, information, discussion, or resources from someone else? Let me know if there is anything I can do.
Depends on: 1223997

Comment 13

3 years ago
Comment on attachment 8666169 [details] [diff] [review]
add-lo-all-locales.patch

Review of attachment 8666169 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, sorry for the lag.

The repo mishaps are now resolved, and the release and beta repos have the aurora history of now after I just pushed.

This is now ready to land and go.
Attachment #8666169 - Flags: review?(l10n) → review+
status-firefox43: --- → affected
Keywords: checkin-needed
(Reporter)

Comment 14

3 years ago
This should only land in mozilla-aurora, making it affect 44, but not 43.
  https://hg.mozilla.org/releases/mozilla-aurora/rev/22939c8dc3c4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → ---
status-firefox44: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.