Closed
Bug 1208639
Opened 9 years ago
Closed 9 years ago
Update homescreen app.py and display.py in settings/regions, and fix affected scripts
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: njpark, Assigned: njpark)
References
Details
Attachments
(1 file)
Homescreen UI is now changed
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → npark
|
|
Assignee | |
Updated•9 years ago
|
No longer blocks: 1207527
Summary: Update homescreen app.py → Update homescreen app.py and display.py in settings/regions, and fix affected scripts
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8666239 -
Flags: review?(martijn.martijn)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8666239 [details] [review] [gaia] npark-mozilla:1208639 > mozilla-b2g:master I think it looks good apart from a few nits, but I wonder about some code that you didn't really touch, only moved. It seems that might give a false positive. If it does, then it should be replaced with a better Wait call.
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8666239 [details] [review] [gaia] npark-mozilla:1208639 > mozilla-b2g:master Just re-ask me for review when you think the pull request is ready.
Attachment #8666239 -
Flags: review?(martijn.martijn)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8666239 [details] [review] [gaia] npark-mozilla:1208639 > mozilla-b2g:master Hi Martijn, addressed all of your comments.
Attachment #8666239 -
Flags: review?(martijn.martijn)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8666239 [details] [review] [gaia] npark-mozilla:1208639 > mozilla-b2g:master Looks good, I understood you tested this pull request locally quite a bit, so I rely on that testing for r+.
Attachment #8666239 -
Flags: review?(martijn.martijn) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/da3ed2865d19b04cc9fa95979fe26773eade3d22
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•