1208647 - minimize a few large libraries to start speeding up Hello standalone page load

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This needs to be applied on top of bug 1188509, and minifies the OpenTok SDK and lodash, shrinking the size of the overload JS to be loaded from ~2.3M to ~1.3M.  

I've added gzip compression to our dev-server so that it's possible to test performance in an environment substantially more similar to production.

These changes have sliced average load time on using Chrome DevTools throttling to 2Mb DSL from ~3.7 seconds down to ~1.8ish seconds.  Slower connections are likely to have even bigger wins.  Presumably, the production servers will perform similarly.

There's lots more low-hanging fruit here for future bugs.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: minify OpenTok SDK and lodash for faster Hello standalone load times

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8666231 [details] [diff] [review]
minify OpenTok SDK and lodash for faster Hello standalone load times

Review of attachment 8666231 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, this is good for me. However, we need to check that TokBox are happy with us shipping the minified version on standalone before we can land this. I'll ask Michael in a moment.

Comment 3

[Mark Banner (:standard8)]

Michael, are you happy with us shipping a minified version of the sdk with our standalone UI?

We'd prefer to minify it ourselves as it provides an easier audit route, obviously the source control version will remain as the one that you supply us.

Comment 4

[msander]

Yes, please go ahead and minify it.

(In reply to Mark Banner (:standard8) from comment #3)
> Michael, are you happy with us shipping a minified version of the sdk with
> our standalone UI?
> 
> We'd prefer to minify it ourselves as it provides an easier audit route,
> obviously the source control version will remain as the one that you supply
> us.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Great, thanks!  Just for posterity, another win for us doing the minification is that once we have all of our stuff run through the minifier, Uglify will be able to do dead-code elimination, which will shrink things even further.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/21015383ac41

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21015383ac41