1208664 - Dump the final composited image and correlate it with paints

Status: NEW

(Core :: Graphics: Layers, defect, P3)

Description

[Botond Ballo [:botond]]

As a complement to the dumping of client-side layer textures in bug 1208661, it's nice to be able to dump the final composited images, and correlate them with the paints that are being composited.

We currently have code to dump the final composited image, but it suffers from two issues:

  (1) It's printed to the same file / stream as client-side textures.
      As the client-side textures and the composited image are
      dumped by different threads, there is a risk of the outputs
      being interleaved. Therefore, the composited images should be
      dumped to a different set of files.

  (2) Since client-side and compositor-side dumps go to different
      files, it would be nice to be able to correlate the two, so
      that you can tell which set of painted textures went into
      producing which composited image.

I have local patches that do this, but they're very hacky; among other things, they're specific to CompositorOGL, and specific to parent-process painting. I'm not sure how landable they are, but I'll post them anyways.

Comment 1

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1208664 - Dump the final composited image and correlate it with paints. r=mattwoodrow

Bug 1208664 - Dump the final composited image and correlate it with paints. r=mattwoodrow

Comment 2

[Botond Ballo [:botond]]

This is my very hacky and not-really-landable patch. I'll think about how to clean it up and make it landable.

Comment 3

[Botond Ballo [:botond]]

Jamie, a tip for unbitrotting this: the condition |gfxUtils::sDumpPainting| should now be |gfxEnv::DumpPaint()|, and the environment variable to turn it on would be MOZ_DUMP_PAINT.

Comment 4

[Botond Ballo [:botond]]

(And sorry that I haven't landed this yet. The main reason is that the handling of the correlation with paint sequence numbers is very hacky, and I'd like to do it more nicely in the version I land.)

Comment 5

[Botond Ballo [:botond]]

I haven't needed to use this in a while and probably not worth spending time unbitrotting it and cleaning it up until I do.