1208666 - 2,000 instances of "WARNING: Suboptimal indexes for the SQL statement" caused by SQL statements in nsDiskCacheDeviceSQL.cpp during linux64 debug testing

Status: RESOLVED WONTFIX

(Core :: Networking: Cache, defect)

Description

[Eric Rahm [:erahm]]

Two SQL statements [1,2] are responsible for about 2,000 warnings during debug testing. We should either add an appropriate index to these tables or add the |/* do not warn (bug ... */| annotation to these.

The warnings:
> 996 - [NNNNN] WARNING: Suboptimal indexes for the SQL statement `SELECT ClientID, ItemType FROM moz_cache WHERE Key = ? ORDER BY LastFetched DESC, LastModified DESC;` [1 sort operation(s)] (http://mzl.la/1FuID0j).: file storage/mozStoragePrivateHelpers.cpp, line 110
> 984 - [NNNNN] WARNING: Suboptimal indexes for the SQL statement `SELECT ns.ClientID, ns.ItemType FROM  moz_cache_namespaces AS ns JOIN moz_cache_groups AS groups  ON ns.ClientID = groups.ActiveClientID WHERE ns.NameSpace <= ?1 AND ?1 GLOB ns.NameSpace || '*' ORDER BY ns.NameSpace DESC, groups.ActivateTimeStamp DESC;` [1 sort operation(s)] (http://mzl.la/1FuID0j).: file storage/mozStoragePrivateHelpers.cpp, line 110

[1] https://dxr.mozilla.org/mozilla-central/rev/5abe3c4deab94270440422c850bbeaf512b1f38d/netwerk/cache/nsDiskCacheDeviceSQL.cpp#1257
[2] https://dxr.mozilla.org/mozilla-central/rev/5abe3c4deab94270440422c850bbeaf512b1f38d/netwerk/cache/nsDiskCacheDeviceSQL.cpp#1261-1265

Comment 1

[Honza Bambas (:mayhemer)]

Appcache code.