1208699 - mozregression invalid literal when creating config

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Ray Satiro]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150921030204

Steps to reproduce:

I'm using mozregression 1.0.1 with Python 2.7.10 in Windows 7 x64.

I attempted to create a persist-size-limit using mozregression --write-config.



Actual results:

There is a prompt to create the size limit for the persist directory:

> You should choose a size limit for the persist dir. I recommend you to use 20.0 GiB, so leave it blank to use that default. Else you can set NONE to not limit the persist dir, or any custom value you like.

I wanted just 2 so I entered:

> persist-size-limit: 2 GiB

ValueError: invalid literal for float(): 2 GiB

I tried again and entered 2000 which I assume is in megabytes and therefore close enough. This may be obvious to some but it wasn't to me.

If the size isn't in megabytes please tell me so I can correct it.


Expected results:

I think you should specify the format. For example if you expect us to enter the size in megabytes then say so.

Comment 1

[Julien Pagès (:parkouss)]

Oh, so the message is not clear enough, sorry. :)

You should just enter a number, e.g: "2.00" or "2" for example for 2GiB - but without the "GiB" extension.

We should fix the message.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: use an explicit message to use a number when --write-config ask for persist size

Ed, could you tell me what you think of the new sentence here ? Is that good for you and self-explanatory ?

Thanks!

Comment 3

[Julien Pagès (:parkouss)]

Comment on attachment 8669268 [details] [review]
use an explicit message to use a number when --write-config ask for persist size

Ray, feel free to review it if you want! I was not sure you wanted so I did not asked, but I'll be happy if you do so.

One review is enough, so I will merge once one of you guys will be good with the change.

Comment 4

[Ray Satiro]

Comment on attachment 8669268 [details] [review]
use an explicit message to use a number when --write-config ask for persist size

There's no need to flag me for review because I'm not following the project so I don't know whether the changes you're making are right or wrong. If I see something I don't understand I may add a line comment on github :) The latest revision makes more sense to me, thanks for your work on this Julien as always.

Comment 5

[Julien Pagès (:parkouss)]

Thanks Ray!

Yeah in fact :emorley is not following the project either, but as it does not involve any code logic I think it is ok - I won't ask you for another kind of review. :)

Thanks for your comment on github! This made a lot of sense, so thanks for doing that and please continue this way!

And btw thanks for the bug reports. You have great ideas, like the --launch and the mapping with build id (we have to look into that). I'm always happy to see new useful features!

Comment 6

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/bfb1a8aaa8795bd8074f4016e40123ad9c0d6f79.