[Dev Theme] bookmarks toolbar has visually darker borders in normal window mode (aka add "background-clip: padding-box;" to #PersonalToolbar)

RESOLVED WORKSFORME

Status

()

Firefox
Theme
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: arni2033, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox44 affected)

Details

(Whiteboard: [fixed by bug 1184651])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8666338 [details]
screenshot - [Dev Theme] bookmarks toolbar has visually darker borders.png

STR:   (Win7_64, Nightly 44, 32bit, ID 20150924030231, new profile, safe mode)
1. Open menu (?) -> click "Customize"
2. Set "Developer Edition" theme, enable bookmarks toolbar, exit customize
3. Make sure you have dark DevTheme: Open devtools (F12), open devtools options (Ctrl+Shift+O), choose "dark theme", close devtools (F12)
4. Resize window to normal mode

Result:       bookmarks toolbar has visually darker borders than navigation toolbar
Expectations: it should have the same visual border color as navigation toolbar

NOTE:
I figured out that toolbars actually use the same border color, but #PersonalToolbar doesn't have "background-clip: padding-box;" rule while #nav-bar has it. That rule fixes the issue.
(Reporter)

Comment 1

2 years ago
This is fixed by 1184651. Also, I see exactly suggested "background-clip: padding-box;" in changelog.
In my understanding, these 2 bugs should be connected in bugzilla somehow.
> Fix range:   https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=4d726b108b2d288a8e25dbda86912116a8da7dfb&tochange=fcf23377f9c3015a884ad531cbab5598d09073a3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Depends on: 1184651
Resolution: --- → WORKSFORME
Whiteboard: [fixed by bug 1184651]
(Reporter)

Updated

2 years ago
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.