1208790 - Magnifying glass icon displayed twice in search hint (French only)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Théo Chevalier]

Attachment: Screenshot of issue / Nightly - French

In the hint about adding search engines, the magnifying glass icon is duplicated in French only (see attached screenshot).

Tried with other locales (it, de, es-ES, pt-BR…), couldn't reproduce. It's a regression from Firefox 41, it does not seem related to the French translation:

><!ENTITY pref_search_hint "ASTUCE : Ajoutez n\u0027importe quel site à votre liste de moteurs de recherche en effectuant un appui long sur leur champ de recherche puis en appuyant sur l\u0027icône &formatI;.">

I see nothing suspicious and this translation hasn't changed recently.

I can reproduce with Nightly 44 and Beta 42.0b1, but *can't* reproduce with latest release, 41. Something got broken in 42, it seems.

STR are simple:

1. Switch to French locale
2. Go to Settings (Paramètres)
3. Go to Customization (Personnalisation)
4. Go to Search (Recherche)

Comment 1

[Francesco Lodolo [:flod]]

The only thing I can find related to that file is this changeset (on all branches but release)
http://hg.mozilla.org/mozilla-central/rev/7635a2e4fa64

It comes from bug 1175354. But I really don't understand enough Android code to know if there's any relation.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

My best guess is that Android is doing some funky text wrapping – the icon can't fit in entirety so it duplicates it on the next line (which would explain why other locales do not hit this).

This changeset may be related in that it probably is responsible for reflowing the text.

Note that I cannot reproduce on my N4 or my GS5 w/ recent Nightly builds, which backs up the text wrapping theory because I wouldn't have the same screen size and thus line length.

Théo, which device are you using? Can you reproduce on any other devices?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

btw, here is the code that inserts the image via spans (which I have not audited):
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/ModifiableHintPreference.java#48

Comment 4

[Théo Chevalier]

(In reply to Michael Comella (:mcomella) from comment #2)
> My best guess is that Android is doing some funky text wrapping – the icon
> can't fit in entirety so it duplicates it on the next line (which would
> explain why other locales do not hit this).
> 
> This changeset may be related in that it probably is responsible for
> reflowing the text.
> 
> Note that I cannot reproduce on my N4 or my GS5 w/ recent Nightly builds,
> which backs up the text wrapping theory because I wouldn't have the same
> screen size and thus line length.
> 
> Théo, which device are you using? Can you reproduce on any other devices?

Hi Michael,

I'm reproducing on a Samsung Galaxy SII with Cyanogen 12.1 Nightly (Android 5.1.1).
Unfortunately (well, that's not really unfortunate), all my other devices are Firefox OS devices.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Kevin, do you have an GS2? Can you repro?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Théo, can you repro in landscape mode?

Comment 7

[Théo Chevalier]

Attachment: Nightly French - Landscape mode

Issue disappear when I switch to landscape mode (and comes back in portrait).

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The quick & easy solution is to back this out – bug 1175354 was a micro-optimization spurred by the linter anyway.

Unfortunately, I can't build multi-locale builds (without putting in more effort, which it's probably not worth atm) so I can't actually create a build to test this. Since it's a straight backout, we'll test on nightly.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Backout changeset 7635a2e4fa64 for regressions in bug 1208790.

Backout changeset 7635a2e4fa64 for regressions in bug 1208790.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1208790 - Add lint ignore for compound drawables in search preference. r=me

Bug 1208790 - Add lint ignore for compound drawables in search preference. r=me

The regression is fixed by the backout of bug 1175354 and this
should ensure it doesn't happen again.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/5dcd78e425fd5708da09853b4f6dbe4ad1424360
Backout changeset 7635a2e4fa64 for regressions in bug 1208790.

https://hg.mozilla.org/integration/fx-team/rev/09584f83e610683714e8eae857733b9c32e13be5
Bug 1208790 - Add lint ignore for compound drawables in search preference. r=me

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Théo, this should be in the 10/7 Nightly – can you verify it's fixed there?

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09584f83e610

Comment 14

[Théo Chevalier]

Thanks Michael, it's fixed in today's Nightly (2015-10-07)