1208791 - Fail mochitests that have "unreachable code after return statement"

Status: NEW

(Testing :: Mochitest, defect)

Description

[Matthew N. [:MattN]]

I don't think there is a valid reason for "unreachable code after return statement" and it's usually a sign of an error/bug so we should fail tests that have this warning so we don't introduce these bugs.

17:33:36     INFO -  JavaScript warning: chrome://mochitests/content/browser/browser/base/content/test/general/browser_documentnavigation.js, line 112: unreachable code after return statement

Comment 1

[Neil Deakin]

The test here should have:

  yield ContentTask...

not return.

Comment 2

[Neil Deakin]

Attachment: Fix

Turns out this was masking an actual bug, that can be reproduced as follows:

1. Load a page and tab to it such that the document is focused (focus ring on document)
2. Click the urlbar to focus it
3. Press Shift+F6

Actual: Nothing appears to happen.
Expected: The document is focused again.

Comment 3

[Neil Deakin]

Let me put that patch in the other bug.