Closed Bug 1208884 Opened 8 years ago Closed 8 years ago

Fix a null check ordering bug in nsHTMLEditRules::SplitParagraph

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Fix a few null check ordering bugs in nsHTMLEditRules::SplitParagraph
2.38 KB, patch
roc
: review+
Details | Diff | Splinter Review 
Found by Viva64.
Attachment #8666500 - Attachment is obsolete: true
I don't think this solution makes sense. In many cases the line directly about this is an NS_ENSURE_STATE(mHtmlEditor), and there are cases where that exists multiple times.
https://hg.mozilla.org/mozilla-central/rev/25ddce309321
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(In reply to Josh Matthews [:jdm] from comment #4)
> I don't think this solution makes sense. In many cases the line directly
> about this is an NS_ENSURE_STATE(mHtmlEditor), and there are cases where
> that exists multiple times.

You're right!  Filed bug 1209037.
Blocks: 710966
You need to log in before you can comment on or make changes to this bug.