Closed
Bug 1208884
Opened 8 years ago
Closed 8 years ago
Fix a null check ordering bug in nsHTMLEditRules::SplitParagraph
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
2.38 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Found by Viva64.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8666500 -
Flags: review?(roc)
Attachment #8666500 -
Flags: review?(roc) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #8666500 -
Attachment is obsolete: true
Attachment #8666526 -
Flags: review?(roc) → review+
Comment 4•8 years ago
|
||
I don't think this solution makes sense. In many cases the line directly about this is an NS_ENSURE_STATE(mHtmlEditor), and there are cases where that exists multiple times.
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/25ddce309321
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Reporter | ||
Comment 6•8 years ago
|
||
(In reply to Josh Matthews [:jdm] from comment #4) > I don't think this solution makes sense. In many cases the line directly > about this is an NS_ENSURE_STATE(mHtmlEditor), and there are cases where > that exists multiple times. You're right! Filed bug 1209037.
You need to log in
before you can comment on or make changes to this bug.
Description
•