Closed
Bug 1208938
Opened 9 years ago
Closed 9 years ago
Further tidy ups now that animations are ticked by their timelines
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
References
Details
Attachments
(3 files, 1 obsolete file)
8.49 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
5.67 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
5.26 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
In bug 1195180 there were some further clean up patches that we didn't land due to bug 1208385. Once bug 1208385 is fixed, we should land those patches, specifically: * attachment 8662222 [details] [diff] [review] * attachment 8662223 [details] [diff] [review] * attachment 8662781 [details] [diff] [review]
Assignee | ||
Comment 1•9 years ago
|
||
This patch renames AnimationCollection::mNeedsRefreshes to indicate that it no longer has any relationship to whether or not we observe the refresh driver.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Animation::Tick contains special handling to cope with pending ready times that are in the future. This was originally introduced to cope with the situation where we are called multiple times per refresh-driver tick. As of bug 1195180, Animation::Tick should no longer be called multiple times per refresh driver tick. It would seem, therefore, that we no longer need to check for a future time. However, since introducing this check, the vsync refresh driver timer has been added which means that we can still have a recorded time from TimeStamp::Now that is ahead of the vsync time used to update the refresh driver. In that case, however, rather than waiting for the next tick, we should simply clamp that pending ready time to the refresh driver time and finish pending immediately.
Assignee | ||
Comment 4•9 years ago
|
||
Not putting this up for review yet because I seem to sometimes hit the following error on try on Linux: dom/animation/test/css-animations/test_animation-reverse.html | reverse() inverts playbackRate - reverse() inverts playbackRate: An attempt was made to use an object that is not, or is no longer, usable e.g. http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bbirtles@mozilla.com-59049fd644f2/try-linux/try_ubuntu32_vm_test-mochitest-1-bm04-tests1-linux32-build1851.txt.gz It seems to be triggered by part 3 but I've no idea how that could cause it.
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Brian Birtles (:birtles) from comment #4) > Not putting this up for review yet because I seem to sometimes hit the > following error on try on Linux: > > dom/animation/test/css-animations/test_animation-reverse.html | reverse() > inverts playbackRate - reverse() inverts playbackRate: An attempt was made > to use an object that is not, or is no longer, usable > > e.g. > http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bbirtles@mozilla. > com-59049fd644f2/try-linux/try_ubuntu32_vm_test-mochitest-1-bm04-tests1- > linux32-build1851.txt.gz > > It seems to be triggered by part 3 but I've no idea how that could cause it. I didn't realise this message is simply what we print when an unhandled InvalidStateError exception is shown. I'm pretty sure this bug is just because we sometimes end up calling reverse() on an infinite animation while currentTime is still 0. That wouldn't happen before since we'd wait longer to start the animation. We simply need to wait an extra frame before reversing.
Assignee | ||
Updated•9 years ago
|
Attachment #8668840 -
Flags: review?(cam)
Assignee | ||
Updated•9 years ago
|
Attachment #8668841 -
Flags: review?(cam)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8669536 -
Flags: review?(cam)
Assignee | ||
Updated•9 years ago
|
Attachment #8668842 -
Attachment is obsolete: true
Assignee | ||
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c3b28977e41
Updated•9 years ago
|
Attachment #8668840 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8668841 -
Flags: review?(cam) → review+
Updated•9 years ago
|
Attachment #8669536 -
Flags: review?(cam) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/89ddaac28785 https://hg.mozilla.org/integration/mozilla-inbound/rev/05f79b5c5ef9 https://hg.mozilla.org/integration/mozilla-inbound/rev/649b90ba9363
https://hg.mozilla.org/mozilla-central/rev/89ddaac28785 https://hg.mozilla.org/mozilla-central/rev/05f79b5c5ef9 https://hg.mozilla.org/mozilla-central/rev/649b90ba9363
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•