Closed Bug 1208985 Opened 10 years ago Closed 10 years ago

`scroll-snap-points-y` percentage values are based on width, not height

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: Swatinem, Assigned: Swatinem)

References

(
URL
)

Details

Attachments

(2 files)

scroll.html
1.04 KB, text/html
Details
MozReview Request: Bug 1208985: Use height for `scroll-snap-points-y` percentage values; r?kip
40 bytes, text/x-review-board-request
kip
: review+
Details
Attached file scroll.html —
The css scroll snapping spec defines the following for `scroll-snap-points-x/y`: > Percentages: relative to same axis of the padding-box of the scroll container However, scroll-snap-points-y values are based on the width of the container, not its height. See the attached testcase.
I have a patch already, just need to write some tests and have my hg account reactivated to submit to mozreview :-D
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Bug 1208985: Use height for `scroll-snap-points-y` percentage values; r?kip The CSS scroll snapping specification defines percentages to be `relative to same axis of the padding-box of the scroll container`, which means that y-axis should be based no height, not width.
Attachment #8666683 - Flags: review?(kgilbert)
Comment on attachment 8666683 [details] MozReview Request: Bug 1208985: Use height for `scroll-snap-points-y` percentage values; r?kip Bug 1208985: Use height for `scroll-snap-points-y` percentage values; r?kip The CSS scroll snapping specification defines percentages to be `relative to same axis of the padding-box of the scroll container`, which means that y-axis should be based no height, not width.
Attachment #8666683 - Flags: review?(kgilbert) → review+
Comment on attachment 8666683 [details] MozReview Request: Bug 1208985: Use height for `scroll-snap-points-y` percentage values; r?kip https://reviewboard.mozilla.org/r/20599/#review18457 Good find, fix looks good.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e59e787c0fe61feb69e21fca8b77fc5f7964dd16 Bug 1208985 - Use height for `scroll-snap-points-y` percentage values; r=kip
https://hg.mozilla.org/mozilla-central/rev/e59e787c0fe6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: