12091 - [PP]Scrolling Bug (presShell->ScrollIntoView)

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P3)

Description

[Eric Pollmann]

This relates to bug 3256.  I added a method to all of the form elements that
gets called when the element receives focus.  This is the method:

void
nsFormControlFrame::ScrollIntoView(nsIPresContext* aPresContext)
{
  if (aPresContext) {
    nsCOMPtr<nsIPresShell> presShell;
    aPresContext->GetShell(getter_AddRefs(presShell));
    presShell->ScrollFrameIntoView(this,
                   NS_PRESSHELL_SCROLL_ANYWHERE,NS_PRESSHELL_SCROLL_ANYWHERE);

  }
}

This scrolls correctly on Win, but on GTK, the widgets get scrolled into the
wrong position.

Ramiro, I've got these changes (many files) in my local tree, so if you want
diff's to play with, I can attach them.  Or you can run/debug the build on
blueviper in /build/ng/mozilla, which already has the changes.

Comment 1

[ramiro]

Eric, I checked in code to fix the keyboard scrolling on gtk.  Check it out and
see if it fixes your bug too.  thanks.

Comment 2

[Eric Pollmann]

Thanks Ramiro, that did the trick!

This bugfix will can be verified by firing up a Linux build and pressing the
Page Down key on Demo 8.  If the screen doesn't look completely messed up, it is
fixed.

Comment 3

[phillip]

verified on build 1999-09-27-08, linux 2.2

Comment 4

[phillip]

clearing status whiteboard