Closed Bug 1209135 Opened 6 years ago Closed 6 years ago
[Music][NGA] Switch sorting logic to use String
.prototype .locale Compare()
For a better l10n experience, String.prototype.localeCompare() should be used. This should provide correct, locale-specific sorting and should also sort numbers correctly (e.g. 1, 2, ... 10 vs. 1, 10, 2, ... ).
Assigning to :squib. Setting NI? for :gandalf regarding usage of String.prototype.localeCompare(). Do we need to get the current locale somehow to use String.prototype.localeCompare()? Or does it automatically detect the current locale?
Assignee: nobody → squibblyflabbetydoo
Depends on: 1208154
Attachment #8669095 - Flags: review?(jdarcangelo)
Comment on attachment 8669095 [details] [review] [gaia] jimporter:music-sort > mozilla-b2g:master Overall looks good! Nice cleanup as well. See my nits in the PR as well as some directions for rebasing the additional script loading.
Attachment #8669095 - Flags: review?(jdarcangelo) → review+
Forgot to resolve this. Landed: https://github.com/mozilla-b2g/gaia/commit/2a5f1f2819c05bb3d8e5a732d18be1739f66bc76
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.