Improve error messaging during |mach configure|

RESOLVED WORKSFORME

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED WORKSFORME
3 years ago
2 months ago

People

(Reporter: toonetown, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8666830 [details]
Contains information about my idk, mozconfig, and the config.status

I get the following error when running |mach configure|

 0:21.49 Reticulating splines...
 0:27.91 Traceback (most recent call last):
 0:27.91   File "./config.status", line 994, in <module>
 0:27.91     config_status(**args)
 0:27.91   File "/Users/ntoone/Documents/Programming/Cerberian/gecko-dev/python/mozbuild/mozbuild/config_status.py", line 149, in config_status
 0:27.91     summary = the_backend.consume(definitions)
 0:27.91   File "/Users/ntoone/Documents/Programming/Cerberian/gecko-dev/python/mozbuild/mozbuild/backend/base.py", line 183, in consume
 0:27.91     self.consume_object(obj)
 0:27.91   File "/Users/ntoone/Documents/Programming/Cerberian/gecko-dev/python/mozbuild/mozbuild/backend/recursivemake.py", line 586, in consume_object
 0:27.91     self._process_java_jar_data(obj.wrapped, backend_file)
 0:27.91   File "/Users/ntoone/Documents/Programming/Cerberian/gecko-dev/python/mozbuild/mozbuild/backend/recursivemake.py", line 1258, in _process_java_jar_data
 0:27.91     (target, ' '.join(jar.extra_jars)))
 0:27.91 TypeError: sequence item 0: expected string or Unicode, NoneType found

Attaching information about my SDK, config.guess, and my mozconfig
(Reporter)

Comment 1

3 years ago
Created attachment 8666835 [details]
Update SDK information - previous one wasn't following symlinks
(Reporter)

Comment 2

3 years ago
I had the following code in a moz.build that was being used:

brandjar.extra_jars = [
    CONFIG['ANDROID_COMPAT_LIB'],
    CONFIG['ANDROID_RECYCLERVIEW_LIB'],
    '$(DEPTH)/mobile/android/javaaddons/javaaddons-1.0.jar',
    '$(DEPTH)/mobile/android/base/constants.jar',
    '$(DEPTH)/mobile/android/base/gecko-browser.jar',
    '$(DEPTH)/mobile/android/base/gecko-mozglue.jar',
    '$(DEPTH)/mobile/android/base/gecko-util.jar'    
]

The error was that the "CONFIG[*]" lines were incorrect - so the values in the extra_jars were null.  This was causing the failure in the recursivemake.py script.

Changing this bug to be "Improved error messaging"
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
(Reporter)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: Error during |mach configure| → Improve error messaging during |mach configure|
We're not doing this kind of "jars by name" in moz.build these days -- and Gradle handles missing files more gracefully -- so this is not relevant any longer.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago2 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.