1209157 - Offset Logviewer lines in the UI, so artifact line 0 is presented to the user as line 1

Status: RESOLVED DUPLICATE of bug 1315808

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

Thanks to :goma, in bug 1108764 we now support line highlighting and line linking in Logviewer.

During the PR we mused we might want to apply a +1 offset to the Logviewer line number, so the text log summary artifact first line number of "0" is rendered as "1" in the UI.

I defer to the end users though, in case this doesn't make sense. Adding a few folks to to the cc'.

Comment 1

[Jonathan French (:jfrench)]

Attachment: currentAppearanceLine0

Current appearance, which displays as line 0.

Comment 2

[Ed Morley [:emorley]]

This was fixed in the log viewer by bug 1315808. Fixing the API (rather than just working around it client side) will happen in bug 1328455.