Closed Bug 1209204 Opened 6 years ago Closed 6 years ago

Change Device Name button keeps focus outline even after pressing cancel on Mac

Categories

(Firefox :: Sync, defect)

Unspecified
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: rfeeley, Assigned: markh)

References

Details

Attachments

(3 files)

Attached image nightly-mac.gif
See Mac example attached. Windows is fine.
Attached image nightly-windows.gif
Windows version that doesn't suffer the blue halo of death.
This was supposed to be fixed as part of bug 1194032 with the code at https://dxr.mozilla.org/mozilla-central/rev/acdb22976ff86539dc10413c5f366e1fb429a680/browser/components/preferences/in-content/sync.js#238 added specifically for this.
Blocks: 1194032
Flags: firefox-backlog+
Matt, we discussed this briefly on IRC. Instead of explicitly choosing the control to focus, this patch allows the focus manager to select it using whatever heuristics it uses. On the mac this causes one of the inline links to get focus instead of the button (ie, the same thing that gets focus if you press "tab" while in that "computer name" box.
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8683969 - Flags: review?(MattN+bmo)
Attachment #8683969 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/db44f45662a8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.