Change Device Name button keeps focus outline even after pressing cancel on Mac

RESOLVED FIXED in Firefox 45

Status

()

Firefox
Sync
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rfeeley, Assigned: markh)

Tracking

unspecified
Firefox 45
Unspecified
Mac OS X
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8666895 [details]
nightly-mac.gif

See Mac example attached. Windows is fine.
(Reporter)

Comment 1

2 years ago
Created attachment 8666899 [details]
nightly-windows.gif

Windows version that doesn't suffer the blue halo of death.
(Assignee)

Comment 2

2 years ago
This was supposed to be fixed as part of bug 1194032 with the code at https://dxr.mozilla.org/mozilla-central/rev/acdb22976ff86539dc10413c5f366e1fb429a680/browser/components/preferences/in-content/sync.js#238 added specifically for this.
Blocks: 1194032
Flags: firefox-backlog+
(Assignee)

Comment 3

2 years ago
Created attachment 8683969 [details] [diff] [review]
0001-Bug-1209204-allow-the-focus-manager-to-select-the-ap.patch

Matt, we discussed this briefly on IRC. Instead of explicitly choosing the control to focus, this patch allows the focus manager to select it using whatever heuristics it uses. On the mac this causes one of the inline links to get focus instead of the button (ie, the same thing that gets focus if you press "tab" while in that "computer name" box.
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8683969 - Flags: review?(MattN+bmo)
Attachment #8683969 - Flags: review?(MattN+bmo) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db44f45662a8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.