1209219 - Add an option to the disable the "X months ago" format for dates

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Botond Ballo [:botond]]

I'm trying out the experimental user interface activated under General Preferences -> "Use experimental user interface". I like it, except for one thing: the dates have all changed from "2015-09-28 16:02 EDT" format to "a minute ago" / "2 months ago" etc. format, which I really dislike. It would be great to provide an option to use the original date format.

Comment 1

[David Lawrence [:dkl]]

(In reply to Botond Ballo [:botond] from comment #0)
> I'm trying out the experimental user interface activated under General
> Preferences -> "Use experimental user interface". I like it, except for one
> thing: the dates have all changed from "2015-09-28 16:02 EDT" format to "a
> minute ago" / "2 months ago" etc. format, which I really dislike. It would
> be great to provide an option to use the original date format.

If you mouse over and of the relative dates, it will show the exact timestamp.

dkl

Comment 2

[Mark Côté [:mcote]]

We already have quite a number of preferences, so we are hesitant to add any more, particularly since, as dkl says, you can get the absolute time, even if it's not displayed by default.

Comment 3

[Botond Ballo [:botond]]

I realize you can mouse over it, but it's still not the same as seeing all dates on the page in your preferred format. It's the sort of thing that's very likely to make me (and I'm guessing, at least some others) switch back to the original interface in spite of the other improvements.

Comment 4

[:glob ✱]

i see value in having this preference, but let's tidy up the prefs page first (bug 1209599).

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1209219_1.patch

- added semicolon to bug-modal.js for consistency/not triggering the linter.
- added user pref for toggling between absolute and relative times on the modal page.
- removed suppoer for calling rel_time.html.tmpl with WRAPPER. We don't do this and supporting it would be annoying.

Relative times are still calculated, and put in the 'title' attribute.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8758918 [details] [diff] [review]
1209219_1.patch

Review of attachment 8758918 [details] [diff] [review]:
-----------------------------------------------------------------

Should we up update these places to do the setting check? Meaning, show the absolute time as the title instead of the relative time like it does now.

https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/template/en/default/bug_modal/flags.html.tmpl#L88
https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/template/en/default/bug_modal/activity_stream.html.tmpl#L161
https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/template/en/default/bug_modal/attachments.html.tmpl#L72
https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl#L249

Comment 7

[David Lawrence [:dkl]]

Also eventually I would like this to be a global setting now just for show_bug.cgi. We should honor this setting for MyDashboard and other reports that currently show relative times. We can create separate bugs for each of the other pages.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

(In reply to David Lawrence [:dkl] from comment #6)
> Comment on attachment 8758918 [details] [diff] [review]
> 1209219_1.patch
> 
> Review of attachment 8758918 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Should we up update these places to do the setting check? Meaning, show the
> absolute time as the title instead of the relative time like it does now.
> 
> https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/
> BugModal/template/en/default/bug_modal/flags.html.tmpl#L88
> https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/
> BugModal/template/en/default/bug_modal/activity_stream.html.tmpl#L161
> https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/
> BugModal/template/en/default/bug_modal/attachments.html.tmpl#L72
> https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/
> BugModal/template/en/default/bug_modal/edit.html.tmpl#L249

I interpreted this bug narrowly -- and I'd prefer that way in light of the recent additional blocking bugs that have been filed.

the decision is yours, as reviewer. :-)

Comment 9

[David Lawrence [:dkl]]

(In reply to Dylan William Hardison [:dylan] from comment #8)
> (In reply to David Lawrence [:dkl] from comment #6)
> I interpreted this bug narrowly -- and I'd prefer that way in light of the
> recent additional blocking bugs that have been filed.

My main reason is we would have a mix of relative and absolute times whereas I would expect when one sets the user preference, all dates would be one or the other. We can work it out as smaller chunks (bugs) if you like.

dkl

Comment 10

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1209219_2.patch

all relative dates in bug_modal should be absolute with that user pref.

note we'll want to figure out how to adjust the times on relative dates when the title= contains more than just a date (right now, they do not update which might be confusing at some point)

Comment 11

[David Lawrence [:dkl]]

Comment on attachment 8759850 [details] [diff] [review]
1209219_2.patch

Review of attachment 8759850 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: extensions/BugModal/template/en/default/bug_modal/flags.html.tmpl
@@ +85,5 @@
>          <span
>        [% END %]
> +        [% IF user.setting("ui_use_absolute_time") == "on"  %]
> +            class="abs-time-title[% " activity-ref" IF activity_id %]"
> +            title="[%~ f.creation_date FILTER time('%Y-%m-%d %H:%M %Z') ~%]"

omit the '~' at the beginning and end brackets.

::: extensions/BugModal/web/bug_modal.js
@@ +149,3 @@
>          });
>  
>      // use non-native tooltips for relative times and bug summaries

Nit: // use non-native tooltips for relative/absolute times and bug summaries

Comment 12

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d2507d1..37b2bd1  master -> master

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

See if this is causing a regression with readable statuses.

Comment 14

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

I think it is, but I need a console log to confirm.

Comment 15

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

It's happening on setting a needinfo.

Comment 16

[Botond Ballo [:botond]]

Thanks a lot for fixing this!