1209268 - Don't assume D3D11CreateDevice() gives back non-null devices

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

When we create anything other than a non-WARP compositor device, we assume D3D11CreateDevice() returning S_OK means that the resulting pointer is non-null. According to crash-stats for InitD3D11Devices, that's not true.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Wrong patch.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Err, and a typo fix.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8666954 [details] [diff] [review]
fix

Review of attachment 8666954 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that typo fixed.

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +2198,5 @@
>    if (!AttemptD3D11ContentDeviceCreationHelper(adapter, hr)) {
>      return FeatureStatus::Crashed;
>    }
>  
> +  if (FAILED(hr) || mD3D11ContentDevice) {

I imagine this is !mD3D11ContentDevice instead?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2886299d081c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2886299d081c