1209278 - Require full mix-blend-mode support in compositors

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

See bug 1207489. Partial support in compositors means we can unexpectedly change the layer manager a stacking context will use while evaluating its descendants. It also adds complexity to APZ.

bug 1207489 is the layout "fix" for this problem, but it's rather hacky and complicated, so we'd like to try this instead.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, strip out SupportsMixBlendMode

This removes SupportsMixBlendMode from layer managers and mSupportedBlendModes from TextureFactoryIdentifier. Anywhere these were used were removed or flattened to assume the condition is always true.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, partial backout of bug 1193557

This is a complete backout of the first part of bug 1193557. In theory none of this is needed anymore since mix-blend mode can't cause inactive layers.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, strip out SupportsMixBlendMode

fix ipc

Comment 4

[Markus Stange [:mstange]]

Looks like you can also remove nsDisplayBlendContainer::mContainedBlendModes and merge the two nsDisplayBlendContainer constructors.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21356fa4e353

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/edb99456bccb for build bustage:

https://treeherder.mozilla.org/logviewer.html#?job_id=22195613&repo=mozilla-inbound

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, follow-up

Remove extra nsDisplayBlendContainer constructor and nsDisplayBlendContainer::mContainedBlendModes.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf30de346f10
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a877b1e3551

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf30de346f10
https://hg.mozilla.org/mozilla-central/rev/5a877b1e3551

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8715425 [details] [diff] [review]
part 1, strip out SupportsMixBlendMode

I'd like to uplift these patches to Beta because they're very low risk and make uplifting bug 1238564 (which in turn is required for bug 1247854) much easier.

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: none - they're only removing unused code. Code that is now unused because all our compositors support all blend modes now; all those patches (see the bugs this bug depends on) are already on Beta.
[Describe test coverage new/current, TreeHerder]: good
[Risks and why]: very low
[String/UUID change made/needed]: none

Comment 11

[Markus Stange [:mstange]]

The patches that need to be uplifted are the ones from this push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=5a877b1e3551

Pulsebot associated the middle one with the wrong bug and didn't leave a comment about it here.

So here's the list again:

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf30de346f10
https://hg.mozilla.org/integration/mozilla-inbound/rev/1699e68d5efb
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a877b1e3551

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Do we have everything on m-c that we need here?
Once we do, I would like to make sure we uplift to aurora and beta.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8715425 [details] [diff] [review]
part 1, strip out SupportsMixBlendMode

Please uplift for aurora and for beta 4, once all 3 patches are landed on m-c,  as we need this to enable APZ by default for the e10s/apz beta rollout.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Sorry, I think this is already on aurora 47 since it landed may 1.   We would like to get it onto beta though.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9133a529cbcd
https://hg.mozilla.org/releases/mozilla-beta/rev/69d2eab7852f

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Wes can you check to make sure you got all 3 patches  mentioned in comment 11?

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, it got stuck into the other bug: https://hg.mozilla.org/releases/mozilla-beta/rev/4315f192ec3a