Closed Bug 1209323 Opened 4 years ago Closed 4 years ago

Turn on plugin telemetry on release channel

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox42 --- affected
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(1 file)

Once we have verified that the plugin telemetry in bug 722110 is working how we expect, we should turn it on as opt-out on release.
Ok. Things look good on the dashboard, should probably open this up to more collection.
Attachment #8670005 - Flags: review?(vladan.bugzilla)
Attachment #8670005 - Flags: review?(cpeterson)
Comment on attachment 8670005 [details] [diff] [review]
Patch 1 (v1) - Set plugin telemetry gathering to release opt-out

Review of attachment 8670005 [details] [diff] [review]:
-----------------------------------------------------------------

f+ because this SGTM but I don't know what the criteria is for making a probe opt-out. Looking at the other releaseChannelCollection probes, they are more serious issues like detecting broken updates. Our plugin telemetry is probably not as critical, so I will let Vladan decide.
Attachment #8670005 - Flags: review?(cpeterson) → feedback+
Comment on attachment 8670005 [details] [diff] [review]
Patch 1 (v1) - Set plugin telemetry gathering to release opt-out

Review of attachment 8670005 [details] [diff] [review]:
-----------------------------------------------------------------

These are the questions that usually get asked for opt-out probes:

* What is the user benefit we are trying to provide by collecting this data?
* What questions are these measurements supposed to answer?
* Who is going to develop the reports to monitor this data after it is collected?
* Who is responsible for owning and monitoring these measurements? How frequently will they be monitored?

Normally, I'd also be concerned about all plugin names being collected on an opt-out basis, since the presence of certain plugins could reveal information about the user, but we already report plugin info in the Environment block of opt-out Telemetry pings
Attachment #8670005 - Flags: review?(vladan.bugzilla)
I'm not sure about the report development/monitoring, so ni'ing cpeterson to answer the questions.
Flags: needinfo?(cpeterson)
(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #3)
> * What is the user benefit we are trying to provide by collecting this data?

By collecting telemetry on plugin use, we can better know when we can remove NPAPI support at some future date. We expect there to be a long-tail of uncommon plugins so the opt-out probe will help us reach those uncommon plugins in the Release channel.

> * What questions are these measurements supposed to answer?

1. Which plugins do users use the most?
2. Is the use of plugins declining?

> * Who is going to develop the reports to monitor this data after it is
> collected?

I will, though I hope to find someone to help develop a dashboard graphing this information.

> * Who is responsible for owning and monitoring these measurements? How
> frequently will they be monitored?

I am. Until I can get someone to help develop a dashboard, I will check the measurements biweekly or monthly.
Flags: needinfo?(cpeterson)
Attachment #8670005 - Flags: review+
Whiteboard: [needs-checkin]
Comment on attachment 8670005 [details] [diff] [review]
Patch 1 (v1) - Set plugin telemetry gathering to release opt-out

Approval Request Comment
[Feature/regressing bug #]: Bug 722110
[User impact if declined]: Less telemetry for plugin usage
[Describe test coverage new/current, TreeHerder]: Been running on opt-in builds for a few weeks, seems ok
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8670005 - Flags: approval-mozilla-beta?
Attachment #8670005 - Flags: approval-mozilla-aurora?
Whiteboard: [needs-checkin] → [checkin-needed]
Whiteboard: [checkin-needed]
https://hg.mozilla.org/mozilla-central/rev/29f2049d529c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Chris, we built beta 9, can it wait 43? Thanks
Flags: needinfo?(cpeterson)
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Chris, we built beta 9, can it wait 43? Thanks

Sure. Waiting for 43 is not a problem.
Flags: needinfo?(cpeterson)
Comment on attachment 8670005 [details] [diff] [review]
Patch 1 (v1) - Set plugin telemetry gathering to release opt-out

Approved for uplift to aurora, as it sounds like we already collect this data in Telemetry in another format.
Attachment #8670005 - Flags: approval-mozilla-beta?
Attachment #8670005 - Flags: approval-mozilla-beta-
Attachment #8670005 - Flags: approval-mozilla-aurora?
Attachment #8670005 - Flags: approval-mozilla-aurora+
Benjamin, does this need extra privacy review? I just realized it might. Thanks.
Flags: needinfo?(benjamin)
One minute and an extra wiki page later I see the Vladan is a peer and has already looked at this. So this should be fine.
Flags: needinfo?(benjamin)
You need to log in before you can comment on or make changes to this bug.