1209334 - Allow holding Ctrl/Cmd while creating a selection to move 1px by 1px

Status: RESOLVED WONTFIX

(DevTools :: Inspector, enhancement, P3)

Description

[Tim Nguyen :ntim]

We should be able to hold Cmd/Crl while creating a selection to make sure the selection only increments/decrements 1px for each mouse mouvement.

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8669355 [details] [diff] [review]
Patch

Review of attachment 8669355 [details] [diff] [review]:
-----------------------------------------------------------------

Forwarding this review to Matteo. He's a better reviewer than me for this.

Some questions though: Can you elaborate the use behind being able to move only pixel per pixel? Also, why bind both ctrl and cmd for this? Maybe we'd like to be able to constrain the width and height to be the same when you hold cmd in the future? Or something like this.

Comment 3

[Tim Nguyen :ntim]

(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #2)
> Comment on attachment 8669355 [details] [diff] [review]
> Patch
> 
> Review of attachment 8669355 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Forwarding this review to Matteo. He's a better reviewer than me for this.
> 
> Some questions though: Can you elaborate the use behind being able to move
> only pixel per pixel? 
Well, usually, when creating a selection, the mouse might go too fast, and it's hard to get a pixel perfect selction. So, it would be nice if we could just hold a key to make sure the selection only increases pixel by pixel.

> Also, why bind both ctrl and cmd for this?
Cmd is usually the standard key for this kind of stuff on OSX. Ctrl is only for compat with other OSes.

> Maybe we'd like to be able to constrain the width and height to be the same when you
> hold cmd in the future? Or something like this.
Yeah, that could help with precision too, but I guess this is covered by bug 1152321. With that bug, I guess you'll be able to resize a selection from one side only.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Tim Nguyen [:ntim] from comment #3)

> (In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #2)
> > Comment on attachment 8669355 [details] [diff] [review]
> > Patch
> > 
> > Review of attachment 8669355 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Forwarding this review to Matteo. He's a better reviewer than me for this.
> > 
> > Some questions though: Can you elaborate the use behind being able to move
> > only pixel per pixel? 
> Well, usually, when creating a selection, the mouse might go too fast, and
> it's hard to get a pixel perfect selction. So, it would be nice if we could
> just hold a key to make sure the selection only increases pixel by pixel.

So, currently for a more accurate measure you can zoom in (using the regular zoom control of the page) as you would have done in Photoshop as well. For the same reason, I'm trying to be consistent with well-known design tool about ux, and during selection those keystroke are used to have different effects (e.g. square selection, centered selection and so on).
I would leave the accuracy to the zoom, and given that the v2 of measuring tool permit to adjust the selection once is made, it should be enough; so we can leave the modifiers keys to the other common behavior.

If we want to have pixel perfection, we should probably do so giving the capability to input the coordinates directly as number – currently we do not have any UI for that, so we could modify the `measure` gcli command.

> > Also, why bind both ctrl and cmd for this?
> Cmd is usually the standard key for this kind of stuff on OSX. Ctrl is only
> for compat with other OSes.

In that case we usually check what is the platform and choose the appropriate modifier – also, sometime the ctrl key is used for something else in OSX.

> > Maybe we'd like to be able to constrain the width and height to be the same when you
> > hold cmd in the future? Or something like this.

Yeah, that something design tools usually does, and it's something I'd like more.

> Yeah, that could help with precision too, but I guess this is covered by bug
> 1152321. With that bug, I guess you'll be able to resize a selection from
> one side only.

So, bug 1152321 will give you the capability to resize the selection using the four corners; I was also thinking to implement arrow's keystroke to move the selection: using a modifier key, we could resize the selection pixel by pixel, that something I think it would be more consistent with the user experience – e.g. by default press arrow up will move the selection by -1px on y axis, but do the same with a modifier key could just reduce by -1px the height; where arrow down will usually move the selection by 1px on y axis, but with a modifier will reduce by -1px the height and move down by 1px.

What do you think?

Comment 5

[Sebastian Zartner [:sebo]]

The general behavior on Windows is:

While creation:
Ctrl: centered resizing
Shift: constrained sizing (i.e. width = height)

While editing:
Ctrl: contered resizing
Shift: constrained sizing (width/height factor stays equal)

And I fully agree with the points mentioned in comment 4 that pixel-perfect selections can be created by zooming the page or editing the selection afterwards.

So, I vote for WONTFIX on this one in favor of implementing the resizing features.

Sebastian

Comment 6

[Julian Descottes [:jdescottes]]

Inspector bug triage. Filter on CLIMBING SHOES.

Matteo, should we WONTFIX this?