1209337 - Push subscription id isn't reset after server deploy

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Edwin Wong [:edwong]]

1. on fx 44 - go here: https://people.mozilla.org/~ewong2/push-notification-test/
2. click pop notification
3. in permissions dialog, select 'Always show notifications'
3. click register SW
4. click subscribe
5. in permissions dialog, click 'always allow push notifications'
6. copy the curl command such as:
curl -I -X POST https://updates.push.services.mozilla.com/push/<LOTS OF CHARS>
7. paste in terminal, and hit enter.
8. deploy a new version to the server
9. repeat step 1-7

actual: no notifications display

expected: you should see native notification display

notes:
[15:33]  <kitcambridge> though edwong gets the same URL each time he subscribes for push, even if his UAID is reset.
[15:33]  <benbangert> wat
[15:33]  <benbangert> kitcambridge: how is that possible?
[15:34]  <kitcambridge> I think we aren't deleting the old push subscription.
[15:35]  <benbangert> we never delete push subscriptions unless a register is sent
[15:37]  <kitcambridge> ahh, yea, we don't bother with dropSubscriptions() if we started with an empty uaid. https://dxr.mozilla.org/mozilla-central/source/dom/push/PushServiceWebSocket.jsm#813
[15:38]  <kitcambridge> that should probably be called unconditionally. if (this._UAID != reply.uaid) { /* ... */ }

Comment 1

[Edwin Wong [:edwong]]

assert fixed by bug 1210943