Add missing includes to `dom/base`

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kitcambridge, Assigned: kitcambridge)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Adding an entry to `UNIFIED_SOURCES` in `dom/base/moz.build` affects how the sources are stitched together. This can trigger "member access into incomplete type" and "_ is not a member of _" errors in other files.
Created attachment 8667042 [details] [diff] [review]
0001-Bug-1209361-Add-missing-includes-to-dom-base-.-r-mcc.patch

Thanks for the pointer on IRC, :mccr8! I tested this out by changing `UNIFIED_SOURCES` to `SOURCES`, recompiling, and adding includes until everything built.
Attachment #8667042 - Flags: review?(continuation)
Comment on attachment 8667042 [details] [diff] [review]
0001-Bug-1209361-Add-missing-includes-to-dom-base-.-r-mcc.patch

Review of attachment 8667042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me. Thanks for fixing this!

::: dom/base/ScreenOrientation.cpp
@@ +11,5 @@
>  #include "nsScreen.h"
>  
> +#include "mozilla/Hal.h"
> +#include "mozilla/Preferences.h"
> +#include "mozilla/DOMEventTargetHelper.h"

DOMEventTargetHelper.h should go before Hal.h
Attachment #8667042 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/7561ecbe5769
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.