Closed Bug 1209361 Opened 4 years ago Closed 4 years ago

Add missing includes to `dom/base`

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file)

Adding an entry to `UNIFIED_SOURCES` in `dom/base/moz.build` affects how the sources are stitched together. This can trigger "member access into incomplete type" and "_ is not a member of _" errors in other files.
Thanks for the pointer on IRC, :mccr8! I tested this out by changing `UNIFIED_SOURCES` to `SOURCES`, recompiling, and adding includes until everything built.
Attachment #8667042 - Flags: review?(continuation)
Comment on attachment 8667042 [details] [diff] [review]
0001-Bug-1209361-Add-missing-includes-to-dom-base-.-r-mcc.patch

Review of attachment 8667042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me. Thanks for fixing this!

::: dom/base/ScreenOrientation.cpp
@@ +11,5 @@
>  #include "nsScreen.h"
>  
> +#include "mozilla/Hal.h"
> +#include "mozilla/Preferences.h"
> +#include "mozilla/DOMEventTargetHelper.h"

DOMEventTargetHelper.h should go before Hal.h
Attachment #8667042 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/7561ecbe5769
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.