1209382 - fetch requests don't show up as XHR requests

Status: RESOLVED FIXED

Description

[Peter Bengtsson [:peterbe]]

Created attachment 8667089 [details]
No cute little XHR badge on that last network request

Steps to reproduce:

1. Visit http://www.peterbe.com/ajaxornot/view6 with the Console panel open. 
2. In the "Net" sub-panel, make sure "XHR" is selected and "Log" is *not*. 
3. Refresh the page if you have to. 

Expected result. 
The javascript does does a fetch() to `/ajaxornot/view6-data`. Expect to see that request in the console with a little XHR badge. 

Actual result.
It doesn't show up. Re-enabling the "Log" option under "Net" you see that these requests are treated like regular file resources like images and CSS.

Comment 1

[Peter Bengtsson [:peterbe]]

Note: This web app uses the native fetch API [0] which perhaps does things differently from jQuery.ajax or ng-http or one of those. The web app has a polyfill [1] but I don't think it's kicking into effect in Fx 43. 

Perhaps the XHR badge is based on the `X-Requested-With: XMLHttpRequest` header. Either way, it's XHR and so it should have the badge I guess. 

[0] https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API
[1] https://github.com/github/fetch

Comment 2

[Brian Grinstead [:bgrins]]

Note that the request also isn't showing up in the netmonitor when the XHR filter is applied

Comment 3

[Brian Grinstead [:bgrins]]

Another example that uses fetch alongside an xhr request: http://jsfiddle.net/8kfr826j/

Comment 4

[Brian Grinstead [:bgrins]]

The fetch request shows up as 'other' in the netmonitor in this example

Comment 5

[Peter Bengtsson [:peterbe]]

Created attachment 8674676 [details]
Screenshot 2015-10-15 21.02.56.png

This demonstrates the problem in Brian's jsfiddle.

But the worst problem is that I often don't want to see the noise of downloading lots of static assets, so normally I switch of "Log" under the Console tab. But I can't with fetch requests.

Comment 6

[Tom Tromey :tromey]

Created attachment 8680169 [details] [diff] [review]
make Fetch requests show up as XHR in network monitor

Comment 7

[Tom Tromey :tromey]

Comment on attachment 8680169 [details] [diff] [review]
make Fetch requests show up as XHR in network monitor

Change the network monitor to categorize Fetch requests as "XHR".

Comment 8

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04596c9a4678

Comment 9

[Tom Tromey :tromey]

Created attachment 8683887 [details] [diff] [review]
make Fetch requests show up as XHR in network monitor

Fix test URL -- worked locally but not in try.

Comment 10

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6011128fdd74

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1092bccf5535

Comment 12

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/1092bccf5535