Closed
Bug 1209384
Opened 10 years ago
Closed 10 years ago
WebGL 2 - GetQuery returns wrong query.
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: u480271, Assigned: u480271)
References
()
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
gl.getQuery(gl.ANY_SAMPLES_PASSED_CONSERVATIVE, gl.CURRENT_QUERY) returns a WebGLQuery object when gl.getQuery(gl.ANY_SAMPLES_PASSED, gl.CURRENT_QUERY) is active, instead of returning null.
Attachment #8667091 -
Flags: review?(jgilbert)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8667091 [details] [diff] [review]
Check active query has same type as target. r=jgilbert
Review of attachment 8667091 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/WebGL2ContextQueries.cpp
@@ +278,2 @@
> nsRefPtr<WebGLQuery> tmp = targetSlot.get();
> + if (tmp != nullptr && tmp->mType != target) {
`tmp` not `tmp != nullptr`.
Attachment #8667091 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•