Don't use preprocessor forced includes for API keys in nsURLFormatter.js

RESOLVED FIXED in Firefox 44

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8667107 [details] [diff] [review]
Don't use preprocessor forced includes for API keys in nsURLFormatter.js

I think this is the only use of the -I option to preprocessor.py in the tree. I'll do a try build to see if we can just remove that option, which I always found confusing, since it doesn't match the C preprocessor at all.
Attachment #8667107 - Flags: review?(gps)
(Assignee)

Comment 2

2 years ago
Unsurprisingly, I was wrong about -I not being used elsewhere:
https://dxr.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8/toolkit/locales/Makefile.in#5

Comment 3

2 years ago
Comment on attachment 8667107 [details] [diff] [review]
Don't use preprocessor forced includes for API keys in nsURLFormatter.js

Review of attachment 8667107 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8667107 - Flags: review?(gps) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eedb958866d
https://hg.mozilla.org/mozilla-central/rev/0eedb958866d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.