Closed Bug 1209410 Opened 4 years ago Closed 4 years ago

Use MP3Demuxer/MediaFormatReader by default when available

Categories

(Core :: Audio/Video: Playback, defect)

43 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

The current code makes assumption based on pref and some static rules.

As we are removing the legacy MP3 readers and instead use the new MP3Demuxer ; we need to test if a MP3 decoder is available on the current PlatformDecoderModule instance.
Blocks: 1207924
changing title, fairly certain there's already a bug opened for it, but can't find it
Summary: Properly implement canPlayType("audio/mpeg") → Use MP3Demuxer/MediaFormatReader by default when available
Assignee: nobody → jyavenard
Following bug 1209410, it was no longer used.
Attachment #8667153 - Flags: review?(ajones)
Comment on attachment 8667147 [details] [diff] [review]
[mp3] P1. Use new MP3Demuxer when possible.

Review of attachment 8667147 [details] [diff] [review]:
-----------------------------------------------------------------

We will need to be on the lookout for regressions from this.
Attachment #8667147 - Flags: review?(cpearce) → review+
Attachment #8667148 - Flags: review?(ajones) → review+
Attachment #8667153 - Flags: review?(ajones) → review+
Following bug 1209410, it was no longer used.
Attachment #8667723 - Flags: review?(ajones)
Comment on attachment 8667723 [details] [diff] [review]
Bug 1209388: [mp3] Remove AppleMP3Reader.

wrong bug #
Attachment #8667723 - Attachment is obsolete: true
Attachment #8667723 - Flags: review?(ajones)
Actually, this cause failure on try as the MP3Demuxer always returns an empty buffered range.

Mark dependency on bug 1194080
Depends on: 1194080
Blocks: 1172419
I plan to rewrite everything in bug 1210667, but in the mean time, this will do.
Attachment #8668766 - Flags: review?(ajones)
The owl.mp3 file and derivative is made of 128 0.026122s long samples , which gives us an actual duration of 3.343616s. However, when decoding those files, the first two samples are dropped by the CoreAudio and WMF decoder giving us an actual play time of 3.29s.
We have no way to determine the exact duration at the demuxing stage. External readers such as DirectShow or GStreamer would only report the decoded frames time, while the MediaFormatReader report the demuxed time.

There is no right answer here. So setting a duration that will allow all readers to pass the tests.

I may have to adjust the duration slightly for Windows XP.
Attachment #8668790 - Flags: review?(cpearce)
Comment on attachment 8667153 [details] [diff] [review]
Bug 1209388: [mp3] Remove AppleMP3Reader.

moved to bug 1209388
Attachment #8667153 - Attachment is obsolete: true
Attachment #8668790 - Flags: review?(cpearce) → review+
Attachment #8668766 - Flags: review?(ajones) → review+
Blocks: 1210711
Depends on: 1214208
See Also: → 1222725
Depends on: 1248179
Depends on: 1256590
No longer depends on: 1256590
You need to log in before you can comment on or make changes to this bug.