Closed
Bug 1209412
Opened 9 years ago
Closed 9 years ago
[nexu-5] HD config
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: contact, Assigned: contact)
Details
Attachments
(3 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150921151815
Steps to reproduce:
BRANCH=master ./config.sh nexus-5[-l]
./build.sh
Actual results:
Small boot animation and incorrect pixel ration.
Expected results:
1080p boot animation and pixel ration = 3
Pixel ratio : http://mydevice.io/devices/
Pull request : https://github.com/mozilla-b2g/device-hammerhead/pull/33
Attachment #8667135 -
Flags: review?(mwu)
Comment 4•9 years ago
|
||
Hmm the thing is, gaia doesn't have assets for 3x. The highest multiplier it has assets for is 2.25x, AFAIK. Does specifying 3x give you the 2.25x assets? Can you try 2.25x and see if it looks any different?
Updated•9 years ago
|
Assignee: nobody → contact
Flags: needinfo?(contact)
Comment 8•9 years ago
|
||
Comment on attachment 8667135 [details] [review]
Pull request
r=me with only one space before :=. Once you've fixed the nit, put checkin-needed in the keywords.
Attachment #8667135 -
Flags: review?(mwu) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8667135 [details] [review]
Pull request
Oops - sorry, this PR is on the wrong branch.
Attachment #8667135 -
Flags: review+
Comment 10•9 years ago
|
||
The scaling configuration is in device.mk. That's the file that needs to be modified. The device config you should be using is nexus-5-l, which uses the b2g-5.1.0_r1 branch.
Assignee | ||
Comment 11•9 years ago
|
||
OK.
And "GAIA_DEV_PIXELS_PER_PX" ? 2.25 or 3 ?
Comment 12•9 years ago
|
||
Judging by how the gaia build system works, I think 2.25 is a safer bet for now.
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #8667135 -
Attachment is obsolete: true
Attachment #8670931 -
Flags: review?(mwu)
Comment 14•9 years ago
|
||
Comment on attachment 8670931 [details] [review]
Pull request
Thanks - looks good.
Attachment #8670931 -
Flags: review?(mwu) → review+
Comment 15•9 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•