1209465 - Space key on Japanese IME doesn't work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Hallvord R. M. Steen [:hallvors]]

Switch to Japanese IME, hiragana mode.
Try to enter space into a text field.

Bug: Firefox doesn't understand you're typing a full-width space, nothing happens at all.

First reported on https://webcompat.com/issues/1281

Comment 1

[:Margaret Leibovic]

jchen, any ideas?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Working on it.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Work around TextComposition workaround (v1)

TextComposition has a workaround where committing a composition as-is
doesn't work, when the composition consists of a single ideographic
space character [1]. This patch works around that workaround by sending
a regular commit event instead of a commit-as-is event.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/events/TextComposition.cpp?rev=f4215b484d52#243

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jim Chen [:jchen] [:darchons] from comment #3)

> TextComposition has a workaround where committing a composition as-is
> doesn't work, when the composition consists of a single ideographic
> space character

Hmm, we should stop using TextComposition in Android widget ASAP... I'm guessing that bug 1199658 is also caused by using TextComposition...

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

I don't think that's relevant... This bug happens when we dispatch eCompositionCommitAsIs, and TextComposition::DispatchCompositionEvent handles the event. It's not directly related to nsWindow using TextComposition.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, I see. I probably misunderstood.

The hack was for old Chinese IMEs on desktop OSes. So, if you'd like better to disable the hack on mobile platforms, I'd agree with that, though.

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8673144 [details] [diff] [review]
Work around TextComposition workaround (v1)

Review of attachment 8673144 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming the old workaround is still required on desktop, I guess that's the best we can do.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add test for committing ideographic space (v1)

Add a test to testInputConnection for committing an ideographic space character.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67ae96f32f6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/edff603cee3e

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67ae96f32f6c
https://hg.mozilla.org/mozilla-central/rev/edff603cee3e

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I believe that it's enough safe to uplift.

Could you try to uplift it to 43?

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch for Beta

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Cannot enter Japanese/Chinese space character in input fields.
[Describe test coverage new/current, TreeHerder]: Locally, m-c
[Risks and why]: Small; patch is a simple workaround.
[String/UUID change made/needed]: None

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8684433 [details] [diff] [review]
Patch for Beta

Low risk fix so android users can type spaces.  
Please uplift to beta.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ffeff840220