1209470 - Remove use of expression closure from Add-on SDK.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tooru Fujisawa [:arai]]

Need to replace non-standard expression closure with one of:
  * function declaration
  * function expression
  * arrow function
before fixing bug 1083458.

converting rules are following:
  * function declaration
    add `return` and braces
  * standalone named function expression
    add `return` and braces
  * function expression, contains `arguments`
    add `return` and braces
  * standalone anonymous function expression contans and receives `this` (Array.filter, bind, etc)
    convert to arrow function, and remove code passing |this|
  * standalone anonymous function expression contans no `this`
    convert to arrow function
  * property with anonymous function expression, contains `this`
    add `return` and braces
  * property with anonymous function expression, contains no `this`, short body
    convert to arrow function
  * property with anonymous function expression, contains no `this`, long body
    add `return` and braces
  * property with named function expression
    add `return` and braces
  * getter property
    add `return` and braces
  * setter property
    add braces

I have draft patches, will post them after test.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove use of expression closure from Add-on SDK.

Comment 2

[Tooru Fujisawa [:arai]]

oh, there's already conflict, let me fix it shortly.

Comment 3

[Tooru Fujisawa [:arai]]

that was a conflict with "let to var" patch.
updated :)

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8667297 [details] [review]
Remove use of expression closure from Add-on SDK.

(In reply to Tooru Fujisawa [:arai] from comment #0)
> converting rules are following:
>   * function declaration
>     add `return` and braces
>   * standalone named function expression
>     add `return` and braces
>   * function expression, contains `arguments`
>     add `return` and braces
>   * standalone anonymous function expression contans and receives `this`
> (Array.filter, bind, etc)
>     convert to arrow function, and remove code passing |this|
>   * standalone anonymous function expression contans no `this`
>     convert to arrow function
>   * property with anonymous function expression, contains `this`
>     add `return` and braces
>   * property with anonymous function expression, contains no `this`, short
> body
>     convert to arrow function
>   * property with anonymous function expression, contains no `this`, long
> body
>     add `return` and braces
>   * property with named function expression
>     add `return` and braces
>   * getter property
>     add `return` and braces
>   * setter property
>     add braces

This looks like the right set of rules and skimming over the patch looks like everything is ok. I'm assuming everything passes on try with this applied in which case please land this in the addon-sdk tree in mercurial.

Comment 5

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b3cd4c97272fdb09d8fc1ed7f16ed3f3f6bfb11
Bug 1209470 - Remove use of expression closure from Add-on SDK. r=mossop

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6b3cd4c97272