1209475 - Search Suggestion prompt is not displayed if the user switches device orientation

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[u549602]

Device: 
Sony Xperia Z2 (Android 5.0.2)
Xiaomi Mi i4 (Android 5.0.2)
Samsung Galaxy S5 (Android 4.4.2)

Tested on Beta (42.0b2), Aurora (43.0a2), and latest Nightly(44.0a1)

Steps to reproduce:
Pre-condition:
Clean Firefox profile from Android Applications Settings before running this testcase.

1.Tap on URL Bar and type anything
2.User switches device orientation (e.g. portrait-> landscape)

Expected result:
1.Just after the first char is typed, the Search Suggestion opt-in prompt is displayed: "Would you like to turn on search suggestions? [Yes] [No]"
2.The prompt is still displayed after the user changes device orientation

Actual result:
1. same as expected
2. The Search Suggestion prompt is not displayed anymore after the device's orientation is changed

Comment 1

[:Margaret Leibovic]

Not a regression, but maybe something we can fix while we're working in this part of the code? Mentor bug?

Comment 2

[Allison Naaktgeboren :ally]

I noticed that the xperia seemed particularly prone to this. Mentor bug sounds good.

Comment 3

[amol1994mane]

i'd like to fix this bug. any pointers?

Comment 4

[:Margaret Leibovic]

Redirecting to ahunt, he's spent more time in this code recently.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to amol1994mane from comment #3)
> i'd like to fix this bug. any pointers?

Hi, amol. We generally recommend having one bug at a time for new contributors. It looks like you've been making progress in bug 1262285 – would you also like to look at bug 1081437? Comment in that bug if you'd like to try it.

Comment 6

[Kevin Lam]

Hi Michael. I'd like to work on this bug.

From what I can see, the problem seems to be that the suggestions prompt is only displayed when the user enters input in the search bar and the listener is evoked. The prompt is left out on orientation change because the view is recreated. Deleting all the input and entering a new character allows the prompt to be displayed again following the change to landscape.

I want to know how you would like this issue to be handled. Thanks.

Comment 7

[Ioana Chiorean]

Kevin, are you still on this? 
I see M Comella is reachable via IRC

Comment 8

[Kevin Lam]

Unfortunately, I am busy handling other work right now. Others are free to tackle this bug.

Comment 9

[Joel Jacob]

I like to fix this bug. Any pointers on where to begin?

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Forwarding request to Nevin – I no longer work on fennec so I will be unable to help.

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Thanks for reporting / and the NI
But I can't reporduce it on 57 Nightly.
Could you please help verify if this problem still exist?
Thank you!

Comment 12

[Joel Jacob]

(In reply to Nevin Chen [:nechen] from comment #11)
> Thanks for reporting / and the NI
> But I can't reporduce it on 57 Nightly.
> Could you please help verify if this problem still exist?
> Thank you!

Yes this problem still exists in version 57.0a1

Comment 13

[u549602]

I can confirm that is still reproducible on the latest Nightly build with the same repro steps.
Tested on a Samsung galaxy S6 EDGE - Android 7.0.

Comment 14

[Joel Jacob]

(In reply to Nevin Chen [:nechen] from comment #11)
> Thanks for reporting / and the NI
> But I can't reporduce it on 57 Nightly.
> Could you please help verify if this problem still exist?
> Thank you!

Could you assign me this bug?

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey Joel - I recommend adding needinfo requests so your questions don't get lost! (type the :nickname for the best autocomplete, e.g. :nechen)

Comment 16

[Joel Jacob]

Could you assign me this bug?

Comment 17

[Joel Jacob]

Could you assign me this bug?
needinfo?([e-mail])

Comment 18

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 19

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.