[New-Homescreen] Edit/remove trays switch operation in RTL

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
In RTL locales, hovering an icon over the edit tray activates the remove tray, and vice-versa.
Created attachment 8667266 [details] [review]
[gaia] Cwiiis:bug1209491-new-homescreen-rtl-tray > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8667266 - Flags: review?(gmarty)
(Assignee)

Updated

3 years ago
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Comment on attachment 8667266 [details] [review]
[gaia] Cwiiis:bug1209491-new-homescreen-rtl-tray > mozilla-b2g:master

LGTM. Thanks!
Attachment #8667266 - Flags: review?(gmarty) → review+
(Assignee)

Comment 3

3 years ago
Cheers, merged: https://github.com/mozilla-b2g/gaia/commit/52017acbba01fe14c15c06b9ba0ff915bb511fc2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Created attachment 8667872 [details] [review]
[gaia] Cwiiis:bug1209491-new-homescreen-rtl-tray > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
I don't see how this could have affected gij(28), the code is entirely unrelated... Let's see what treeherder says with a new push: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=a3b69d6c63ccf069d7cffba08fa4b8e5640b05ef
(Assignee)

Comment 7

3 years ago
Comment on attachment 8667872 [details] [review]
[gaia] Cwiiis:bug1209491-new-homescreen-rtl-tray > mozilla-b2g:master

Carrying r=gmarty
Attachment #8667872 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8667266 - Attachment is obsolete: true
(Assignee)

Comment 8

3 years ago
Everything's green, merged again: https://github.com/mozilla-b2g/gaia/commit/ece0c014925c70ec65a0e8cee4e4101664f2ce58
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.