1209508 - Certain bugzilla pages and GitHub issues makes *all* tabs to crash on Linux

Status: VERIFIED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Armen [:armenzg]]

After updating my nightly I consistenly have my tabs getting crashed.

I pin pointed that loading a specific bug or trying to file a bug or loading a GitHub issue will crash all my tabs.
Once I have no more of such tabs, I can restore all my tabs without crashing again.

Here's one of my many crashes:
https://crash-stats.mozilla.com/report/index/e7fa0e6d-1c93-49c2-9c8a-c88b22150929

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Crash Reason 	SIGSEGV
Crash Address 	0x0

Top 10 frames:

0 	libxul.so 	mozilla::OriginAttributes::CreateSuffix(nsACString_internal&) const 	caps/BasePrincipal.cpp
1 	libxul.so 	mozilla::dom::StructuredCloneHelper::WriteFullySerializableObjects(JSContext*, JSStructuredCloneWriter*, JS::Handle<JSObject*>) 	dom/base/StructuredCloneHelper.cpp
2 	libxul.so 	mozilla::dom::StructuredCloneHelper::WriteCallback(JSContext*, JSStructuredCloneWriter*, JS::Handle<JSObject*>) 	dom/base/StructuredCloneHelper.cpp
3 	libxul.so 	JSStructuredCloneWriter::startWrite(JS::Handle<JS::Value>) 	js/src/vm/StructuredClone.cpp
4 	libxul.so 	JSStructuredCloneWriter::write(JS::Handle<JS::Value>) 	js/src/vm/StructuredClone.cpp
5 	libxul.so 	WriteStructuredClone(JSContext*, JS::Handle<JS::Value>, unsigned long**, unsigned long*, JSStructuredCloneCallbacks const*, void*, JS::Value) 	js/src/vm/StructuredClone.cpp
6 	libxul.so 	JS_WriteStructuredClone(JSContext*, JS::Handle<JS::Value>, unsigned long**, unsigned long*, JSStructuredCloneCallbacks const*, void*, JS::Handle<JS::Value>) 	js/src/vm/StructuredClone.cpp
7 	libxul.so 	JSAutoStructuredCloneBuffer::write(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JSStructuredCloneCallbacks const*, void*) 	js/src/vm/StructuredClone.cpp
8 	libxul.so 	mozilla::dom::StructuredCloneHelperInternal::Write(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>) 	dom/base/StructuredCloneHelper.cpp
9 	libxul.so 	mozilla::dom::StructuredCloneHelper::Write(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, mozilla::ErrorResult&) 	dom/base/StructuredCloneHelper.cpp
10 	libxul.so 	mozilla::dom::ipc::StructuredCloneData::Write(JSContext*, JS::Handle<JS::Value>, mozilla::ErrorResult&) 	dom/ipc/StructuredCloneData.cpp

There are also other reports available for OS X. See the attached URL.

Comment 2

[Armen [:armenzg]]

Disabling Adblock Plus takes away the crashes.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Armen Zambrano Gasparnian [:armenzg] from comment #2)
> Disabling Adblock Plus takes away the crashes.

Interesting. So I also updated to latest Nightly on Ubuntu 15.04 64bit but I don't have this problem with ADB version 2.6.11.

I will cc Wladimir from the ADB team for information.

Comment 4

[Wladimir Palant]

StructuredCloneHelper probably means that this is a CPOW issue?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume this might have been caused by bug 1167100 and the crashes should be fixed with the backout of the changeset. Armen can you please retest the 2nd nightly build from yesterday?

Comment 6

[Armen [:armenzg]]

Leaving NI in place. I will try again tomorrow when I'm back to my Linux machine.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See Bug 1209843 as Bobby will remove those ASSERTs.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yoshi, so we can mark this bug fixed based on the backout on bug 1167100?

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Yes, maybe duplicated with Bug 1209843.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Yoshi. So this crash has been fixed with the backout of the patch in bug 1167100.

Armen, if you still want to check please feel free, but it's not really necessary anymore.

Comment 11

[Armen [:armenzg]]

It works.