Closed
Bug 1209519
Opened 9 years ago
Closed 9 years ago
DocumentTimeline.h build bustage with --disable-accessibility
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: RyanVM, Unassigned)
References
Details
Attachments
(1 file)
|
958 bytes,
patch
|
birtles
:
review+
|
Details | Diff | Splinter Review |
Started hitting this today after bug 1195180 landed. I've confirmed that dropping --disable-accessibility from my .mozconfig fixes it.
mozilla-central\objdir-fx-64\dist\include\mozilla/dom/DocumentTimeline.h(48) : error C3668: 'mozilla::dom::DocumentTimeline::GetTickCount' : method with override specifier 'override' did not override any base class methods
Flags: needinfo?(bbirtles)
|
Reporter | |
Comment 1•9 years ago
|
||
Various other files that use GetCurrentTime (like AnimationTimeline.h) have a check for GetCurrentTime and undef it if set. Doing the same in DocumentTimeline.h fixes the bustage for me.
Attachment #8667276 -
Flags: review?(bbirtles)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8667276 [details] [diff] [review]
possible patch
Thanks for taking care of this!
Flags: needinfo?(bbirtles)
Attachment #8667276 -
Flags: review?(bbirtles) → review+
|
||
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•