DocumentTimeline.h build bustage with --disable-accessibility

RESOLVED FIXED in Firefox 44

Status

()

Product:
Core
Component:
DOM: Animation
Status:
RESOLVED FIXED
Reported:
3 years ago
Modified:
3 years ago

People

(Reporter: RyanVM, Unassigned)

Tracking

Version:
Trunk
Target:
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

possible patch
958 bytes, patch
birtles
: review+
Details | Diff | Splinter Review
(Reporter)

Description

•
3 years ago 
Started hitting this today after bug 1195180 landed. I've confirmed that dropping --disable-accessibility from my .mozconfig fixes it.

mozilla-central\objdir-fx-64\dist\include\mozilla/dom/DocumentTimeline.h(48) : error C3668: 'mozilla::dom::DocumentTimeline::GetTickCount' : method with override specifier 'override' did not override any base class methods
Flags: needinfo?(bbirtles)
(Reporter)

Comment 1

•
3 years ago 
Created attachment 8667276 [details] [diff] [review]
possible patch

Various other files that use GetCurrentTime (like AnimationTimeline.h) have a check for GetCurrentTime and undef it if set. Doing the same in DocumentTimeline.h fixes the bustage for me.
Attachment #8667276 - Flags: review?(bbirtles)

Comment 2

•
3 years ago 
Comment on attachment 8667276 [details] [diff] [review]
possible patch

Thanks for taking care of this!
Flags: needinfo?(bbirtles)
Attachment #8667276 - Flags: review?(bbirtles) → review+

Comment 4

•
3 years ago 
https://hg.mozilla.org/mozilla-central/rev/ce3c0f04de50
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.