Closed Bug 1209519 Opened 4 years ago Closed 4 years ago

DocumentTimeline.h build bustage with --disable-accessibility

Categories

(Core :: DOM: Animation, defect)

Product:
Core
Component:
DOM: Animation
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: RyanVM, Unassigned)

References

Details

Attachments

(1 file)

possible patch
958 bytes, patch
birtles
: review+
Details | Diff | Splinter Review 
Started hitting this today after bug 1195180 landed. I've confirmed that dropping --disable-accessibility from my .mozconfig fixes it.

mozilla-central\objdir-fx-64\dist\include\mozilla/dom/DocumentTimeline.h(48) : error C3668: 'mozilla::dom::DocumentTimeline::GetTickCount' : method with override specifier 'override' did not override any base class methods
Flags: needinfo?(bbirtles)
Attached patch possible patch — — Splinter Review 
Various other files that use GetCurrentTime (like AnimationTimeline.h) have a check for GetCurrentTime and undef it if set. Doing the same in DocumentTimeline.h fixes the bustage for me.
Attachment #8667276 - Flags: review?(bbirtles)
Comment on attachment 8667276 [details] [diff] [review]
possible patch

Thanks for taking care of this!
Flags: needinfo?(bbirtles)
Attachment #8667276 - Flags: review?(bbirtles) → review+
https://hg.mozilla.org/mozilla-central/rev/ce3c0f04de50
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.