1209528 - IonMonkey: MIPS32: Add suffix 'f' for constant float32.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS32-Add-suffix-f-for-constant-float32.patch

Thanks!

Comment 1

[Tooru Fujisawa [:arai]]

Comment on attachment 8667282 [details] [diff] [review]
0001-IonMonkey-MIPS32-Add-suffix-f-for-constant-float32.patch

Review of attachment 8667282 [details] [diff] [review]:
-----------------------------------------------------------------

The change itself looks good :)

btw, there are some more callsites with possibly float constant (-1 and 0.5), are you going to fix them in other bug?
https://dxr.mozilla.org/mozilla-central/search?q=path%3Amips32+loadConstantFloat32%28&redirect=false&case=false&limit=75&offset=0

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9545e9e23ff5

Comment 3

[hev [:hev]]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> Comment on attachment 8667282 [details] [diff] [review]
> 0001-IonMonkey-MIPS32-Add-suffix-f-for-constant-float32.patch
> 
> Review of attachment 8667282 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The change itself looks good :)
> 
> btw, there are some more callsites with possibly float constant (-1 and
> 0.5), are you going to fix them in other bug?
> https://dxr.mozilla.org/mozilla-central/
> search?q=path%3Amips32+loadConstantFloat32%28&redirect=false&case=false&limit
> =75&offset=0
good! thanks! ;)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9545e9e23ff5