1209530 - add-on content tools login button doesn't go to fxa login

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[Andrew Williamson [:eviljeff]]

The Login button always goes to the register page instead of the login page.

Comment 1

[David Durst [:ddurst]]

Is this still an issue? it works fine for me

Comment 2

[Chuck Harmston [:chuck]]

Yes. Make sure your account is cleared first (i.e. click on "Use a different account")

Comment 3

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/marketplace-content-tools/pull/64

Removing the Register button entirely since it doesn't do anything differently from the Login button. This issue may still exist, but it's all FXA logic that we have no control over.

Comment 4

[Kevin Ngo [:ngoke]]

STR:

Expected:

Register buttons removed. FXA will still take you to the register page if it doesn't detect a previous session.

Comment 5

[Andrew Williamson [:eviljeff]]

If fireplace can do it, why can't content-tools do it?  In the consumer pages, Register goes to `/oauth/signup`; Login goes to `/oauth/signin`.  For content tools they both seem to go to /oauth and fxa redirects.

Comment 6

[Kevin Ngo [:ngoke]]

Ah, must be because we're using fxa-dev on -dev.

Comment 7

[Kevin Ngo [:ngoke]]

It should work on stage once we get to that point then.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Hey Kevin, could you clarify the fxa-dev comment? We'd like to run automated tests on both dev and staging so would like to have these flows being consistent. FYI, we also saw this on fireplace and raised bug 1162010.

Comment 9

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/marketplace-content-tools/commit/33924459e8dc2f121f0b9428226fd2ca53b9f37f

Comment 10

[Bob Silverberg [:bsilverberg]]

Thanks for this fix, Kevin. This makes it much easier to write an automated test.