Closed Bug 1209552 Opened 9 years ago Closed 9 years ago

Point current music tests to devapps/music-oga

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: njpark, Assigned: njpark)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1208553 +++

The music-NGA app (the new Music app after the swap) is internally in many ways different from the Music app.  Need to point current Music app tests to the older Music app, which is the Music-OGA app under devapps folder.
Depends on: 1209584
Assignee: nobody → npark
Comment on attachment 8667499 [details] [review]
[gaia] npark-mozilla:1209522 > mozilla-b2g:master

Initial attempt to point our music tests to music-oga.

I think we do need to rename our apps/music folder to apps/music_oga folder, since they are no longer usable with the new Music app.
Attachment #8667499 - Flags: review?(martijn.martijn)
Attachment #8667499 - Flags: review?(jlorenzo)
No longer depends on: 1208553, 1209584, 1194224
Comment on attachment 8667499 [details] [review]
[gaia] npark-mozilla:1209522 > mozilla-b2g:master

Thanks!
Attachment #8667499 - Flags: review?(martijn.martijn) → review+
Comment on attachment 8667499 [details] [review]
[gaia] npark-mozilla:1209522 > mozilla-b2g:master

As we don't know if they'll switch back, I'm fine with moving the pages classes to music_oga. I checked with PyCharm where the music page class was called and I found exactly the same 13 places you have. It all looks good to me.
Attachment #8667499 - Flags: review?(jlorenzo) → review+
Merged:
https://github.com/mozilla-b2g/gaia/commit/a0eccdae54b8cc2a11c3b1836734458119e68304
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: