Closed Bug 1209561 Opened 6 years ago Closed 6 years ago

Pushing to try with bind-autoland produces a try string in double quotes which breaks try syntax

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gijs, Assigned: dminor)

Details

Attachments

(1 file)

Examples:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11970dcb67a1

has no tests (despite -u all)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=102c5636cbc4

has no talos runs (despite -t all)

etc. etc.


The quotes should just not be there.
Filed bug 1209568 on the try syntax parser.

Steven, do you know someone who could work on this (or move it to the right place or whatever) ?
Flags: needinfo?(smacleod)
I can work on this.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Flags: needinfo?(smacleod)
autoland: stop quoting try syntax (bug 1209561) r?gps

Quoting try syntax breaks the try syntax parser so we shouldn't do that.
Attachment #8667345 - Flags: review?(gps)
Test try run made through autoland-dev:

https://treeherder.allizom.org/#/jobs?repo=try&revision=5cea3ee42e81
Comment on attachment 8667345 [details]
MozReview Request: autoland: stop quoting try syntax (bug 1209561) r?gps

https://reviewboard.mozilla.org/r/20713/#review18587
Attachment #8667345 - Flags: review?(gps) → review+
Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/46a03de8e9a8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.