1209561 - Pushing to try with bind-autoland produces a try string in double quotes which breaks try syntax

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[:Gijs (he/him)]

Examples:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11970dcb67a1

has no tests (despite -u all)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=102c5636cbc4

has no talos runs (despite -t all)

etc. etc.


The quotes should just not be there.

Comment 1

[:Gijs (he/him)]

Filed bug 1209568 on the try syntax parser.

Steven, do you know someone who could work on this (or move it to the right place or whatever) ?

Comment 2

[Dan Minor [:dminor]]

I can work on this.

Comment 3

[Dan Minor [:dminor]]

Attachment: MozReview Request: autoland: stop quoting try syntax (bug 1209561) r?gps

autoland: stop quoting try syntax (bug 1209561) r?gps

Quoting try syntax breaks the try syntax parser so we shouldn't do that.

Comment 4

[Dan Minor [:dminor]]

Test try run made through autoland-dev:

https://treeherder.allizom.org/#/jobs?repo=try&revision=5cea3ee42e81

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8667345 [details]
MozReview Request: autoland: stop quoting try syntax (bug 1209561) r?gps

https://reviewboard.mozilla.org/r/20713/#review18587

Comment 6

[Dan Minor [:dminor]]

Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/46a03de8e9a8