1209592 - Share your screen dropdown misplaced when window is large

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Ian Bicking (:ianbicking)]

Attachment: Screen Shot

See attached screenshot (made when Hello was maximized)

Firefox 44.0a1 (2015-09-28)

Comment 1

[:shell escalante]

while we're planning to remove the button - it's there in 43.  believe there's already a bug on this as well.  will do if quick

Comment 2

[Mark Banner (:standard8)]

Attachment: Fix Loop's screenshare dropdown being misplaced on large window sizes.

Looks like we just need to swap to an anchor, and drop the styles that are getting in the way.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8668614 [details] [diff] [review]
Fix Loop's screenshare dropdown being misplaced on large window sizes.

Review of attachment 8668614 [details] [diff] [review]:
-----------------------------------------------------------------

Neat!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0ee75d7cc16b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ee75d7cc16b

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8668614 [details] [diff] [review]
Fix Loop's screenshare dropdown being misplaced on large window sizes.

Approval Request Comment
[Feature/regressing bug #]: Visual refresh toolbar work. Probably bug 1184559
[User impact if declined]: If using the popped-out view of the conversation window, the dropdown menu for the screen share selection appears in the wrong place.
[Describe test coverage new/current, TreeHerder]: Code covered by unit tests.
[Risks and why]: Mainly css, the code change supports css, so low risk, only affects Hello
[String/UUID change made/needed]: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a recent regression.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8668614 [details] [diff] [review]
Fix Loop's screenshare dropdown being misplaced on large window sizes.

Approved for aurora uplift; fix for recent regression

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/192e84036f5a