DuckDuckGo not offered in 2015-09-29 Nightly, reverted to Yahoo

VERIFIED FIXED in Firefox 44

Status

()

Firefox
Search
P1
major
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: callahad, Assigned: glandium)

Tracking

({DevAdvocacy})

Trunk
Firefox 44
DevAdvocacy
Points:
---

Firefox Tracking Flags

(firefox44 verified)

Details

(Whiteboard: [fxsearch][bugday-20151202])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
New profiles created with Nightly 2015-09-29 (build id 20150929030225, rev acdb22976ff86539dc10413c5f366e1fb429a680) do not offer DuckDuckGo as a search option.

My existing profile lost DuckDuckGo and forced me back to Yahoo, despite DDG being the only engine I had installed / configured at the time of the update.
(Reporter)

Comment 1

3 years ago
Nightly builds from 2015-09-28 (build id 20150928030206, rev 6256ec9113c115141aab089c45ee69438884b680) do offer DDG as a search option, so it looks like a regression somewhere between 6256ec9113c115141aab089c45ee69438884b680 and acdb22976ff86539dc10413c5f366e1fb429a680

Comment 2

3 years ago
mozregression --good 2015-09-28 --bad 2015-09-29
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=37e7c82c0fc3a8d677f9209cb77de8df77858adb&tochange=6c9db53f98d563afe40715d936f9129c05596915

FWIW, inspecting list.txt from chrome://browser/locale/searchplugins/ (because https://hg.mozilla.org/integration/mozilla-inbound/rev/f1769f48b3c0)
there is "ddg" on Build ID:20150928030206, no "ddg" in Build ID:20150929030225.
there's a bunch of changes from glandium there, he may tell us more
Flags: needinfo?(mh+mozilla)
Priority: -- → P1
Whiteboard: [fxsearch]
I verified locally that reverting f1769f48b3c0 fixes it for me.
Blocks: 1207882
We probably would not have problems specific to DuckDuckGo if we had fixed bug 1105092. Maybe that's what we should do.
(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> We probably would not have problems specific to DuckDuckGo if we had fixed
> bug 1105092. Maybe that's what we should do.

I'm not convinced bug 1105092 is a great choice, unless we're willing to accept the chance to lose DDG for a few locales.

The fix needs to land in 100 repositories. I can do that, it might take a bit of time. But that doesn't ensure that it's going to ship if the locale is not keeping the localization up to date.
(Assignee)

Comment 7

3 years ago
Created attachment 8668154 [details] [diff] [review]
Limit using source searchplugin files directly to `mach build faster` until bug 1105092 is fixed

sigh
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Attachment #8668154 - Flags: review?(gps)

Comment 8

3 years ago
Comment on attachment 8668154 [details] [diff] [review]
Limit using source searchplugin files directly to `mach build faster` until bug 1105092 is fixed

Review of attachment 8668154 [details] [diff] [review]:
-----------------------------------------------------------------

I hate packaging operations that the mozilla-central build system and try automation has little insight into :/
Attachment #8668154 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/190f5eeec41a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Reproduced this bug with Firefox Nightly 44.0a1 (2015-09-29);(Build ID: 20150929030225) on Linux, 64 Bit 	

This Bug is now verified as fixed on Latest Firefox Dev Edition 44.0a2 (2015-12-02)

Build ID: 20151202004004
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [bugday-20151202]
I have reproduced this bug with Firefox Nightly 44.0a1 (Build ID: 20150929030225) on 
windows 8.1 64-bit .

Verified as fixed with latest Firefox Developer edition 44.0a2 (Build ID: 20151202004004)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

As, this bug is also verified on Linux (Comment 11),I am marking this as verified.
Status: RESOLVED → VERIFIED
status-firefox44: fixed → verified
Whiteboard: [fxsearch] → [fxsearch][bugday-20151202]
You need to log in before you can comment on or make changes to this bug.