1209614 - add treeherder support for new partner apk and b2gdroid apk variants

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Jordan Lund (:jlund)]

Attachment: treeherder PR

Comment 2

[Jordan Lund (:jlund)]

Attachment: 151013_treeherder_support_b2gdroid_partner-m-c.patch

this is the accompanying patch. feel free to bounce if you are not comfortable with this part.

prior to this patch, I was piggy backing on the 4.0 api 11+ variant so we had 3 builds on one line. We would like to have partner sample 1 (dummy apk proof of concept) and b2gdroid on their own line as they will eventually have their own tests/updates

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8673219 [details] [review]
treeherder PR

Cancelling review pending https://github.com/mozilla/treeherder/pull/1063#discussion_r41910763

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8673219 [details] [review]
treeherder PR

re-submitting r? given nicks comment in github.

pinging you cam because b2gdroid would benefit from this asap and I believe edmorely is gone for the day.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8673219 [details] [review]
treeherder PR

Jordan- please try to trim the name just a bit, per Ed's comment and mine on the PR.  Thanks.  Please reassign to me or Ed when you're done.

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8673221 [details] [diff] [review]
151013_treeherder_support_b2gdroid_partner-m-c.patch

While these changes all look fine to me in principle, I don't really feel qualified to review task cluster code.  Would you be able to have garndt or jonasfj take a look as well?

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8673219 [details] [review]
treeherder PR

thanks for the review. I've reduced it to 23 chars :)

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8673221 [details] [diff] [review]
151013_treeherder_support_b2gdroid_partner-m-c.patch

Review of attachment 8673221 [details] [diff] [review]:
-----------------------------------------------------------------

sounds good. I'll ask dustin as he has context on these builders.

Dustin, I've changed the expected treeherder platform name: https://github.com/mozilla/treeherder/pull/1063

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8673219 [details] [review]
treeherder PR

Thanks man!  :)  Did you need me to merge this?  or do you have access?

Comment 10

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #9)
> Thanks man!  :)  Did you need me to merge this?  or do you have access?

The vast majority of people don't have access, since I pruned the list of teams linked to the repo a few months ago, due to us deploying on push on Heroku, and due to having commit access basically being the same as having root for stage/prod (since update.py runs as root) - and we have no way to know if people have 2FA enabled etc. The list of collaborators can be seen here:
https://github.com/orgs/mozilla/teams/treeherder

Comment 11

[Jordan Lund (:jlund)]

cool,

camd said he would merge for me. the PR commits have been squashed and commit msg updated. ready to be merged

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcaf914d0390

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/409bf13e6c6b5f1ff397923dc95bf0307ac6f7a8
Bug 1209614 - add treeherder support for new partner apk and b2gdroid apk variants, r=camd

https://github.com/mozilla/treeherder/commit/50d91f637da5b7b4b8125209c1fbd5a4c44c0630
Merge pull request #1063 from lundjordan/master

Bug 1209614 - add treeherder support for new partner apk and b2gdroid

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcaf914d0390

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcaf914d0390