Closed
Bug 1209620
Opened 9 years ago
Closed 9 years ago
Functional tests intermittent failure: TEST-UNEXPECTED-ERROR | Test1BrowserCall.test_1_browser_call | NoSuchElementException | Unable to locate element: .new-room-view .btn-info
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox44 fixed)
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
We've been seeing a lot of these just recently: TEST-UNEXPECTED-ERROR | test_1_browser_call.py Test1BrowserCall.test_1_browser_call | NoSuchElementException: NoSuchElementException: Unable to locate element: .new-room-view .btn-info Traceback (most recent call last): File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_client-0.20-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/marionette/tests/browser/components/loop/test/functional/test_1_browser_call.py", line 228, in test_1_browser_call self.local_start_a_conversation() File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/marionette/tests/browser/components/loop/test/functional/test_1_browser_call.py", line 92, in local_start_a_conversation button = self.marionette.find_element(By.CSS_SELECTOR, ".new-room-view .btn-info") File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.13-py2.7.egg/marionette_driver/marionette.py", line 1579, in find_element el = self._send_message("findElement", body, key="value") File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.13-py2.7.egg/marionette_driver/decorators.py", line 36, in _ return func(*args, **kwargs) File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.13-py2.7.egg/marionette_driver/marionette.py", line 711, in _send_message self._handle_error(resp) File "/home/mozilla/jenkins/workspace/hello-e2e-marionette/venv/local/lib/python2.7/site-packages/marionette_driver-0.13-py2.7.egg/marionette_driver/marionette.py", line 752, in _handle_error raise errors.lookup(error)(message, stacktrace=stacktrace) I think the fix is simple, patch coming up. (P1 as this is a frequent intermittent fail)
Assignee | ||
Comment 1•9 years ago
|
||
We're not waiting for the button to be displayed, I suspect there's some small delays somewhere (anything more than zero is long enough trigger this). I've tested this locally by adding a delay to panel.jsx in rendering the panel.
Attachment #8667397 -
Flags: review?(dmose)
Comment 2•9 years ago
|
||
Comment on attachment 8667397 [details] [diff] [review] Fix intermittent failure finding the start a conversation button in Loop's functional tests. NPOTB DONTBUILD Review of attachment 8667397 [details] [diff] [review]: ----------------------------------------------------------------- Thanks so much; r=dmose!
Attachment #8667397 -
Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/5c0821e57fc6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•