1209661 - When selecting a song from the music app, the albums background dims for a second.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[[:VladimirBelonenko]]

Attachment: logcat_20150929_1104.txt

Description:
When user selects a song from  the music app, before it plays the background flickers for a moment.

Repro Steps:
1) Update a Aries to 20150929110451
2) Open music app
3) Select  a song
4) Observe that before the songs plays background triggers for a second.

Actual:
User selects a song and it goes dark for a moment.

Expected:
When selecting a song it should not trigger a background.

Notes: Try to select a songs with yellow or light backgrounds.

Environmental Variables:
Device: Aries Master 2.5 kk full flash (319 mb)
Build ID: 20150929110451
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 3/3
See attached: video clip and logcat

Comment 1

[[:VladimirBelonenko]]

This issue does not occur on flame 2.5
Result: When user selects a song the background did not trigger. 

Environmental Variables:
Device: Flame Master 2.5 kk full flash (319 mb)
Build ID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 2

[[:VladimirBelonenko]]

This issue occur on flame 2.5
Result: When user selects a song the background dims. 

Environmental Variables:
Device: Flame Master 2.5 kk full flash (319 mb)
Build ID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

No-Jun, can you take a look at this please?

Comment 4

[No-Jun Park [:njpark]]

This is probably the NGA bug.  Could you also see whether this repros in flame device?  because I never saw this on Flame.  adding qawanted for it.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1209661 > mozilla-b2g:master

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8667551 [details] [review]
[gaia] justindarc:bug1209661 > mozilla-b2g:master

This prevents the album artwork from cross-fading with itself causing momentary dimness.

Comment 7

[Justin D'Arcangelo [:justindarc]]

(In reply to No-Jun Park [:njpark] from comment #4)
> This is probably the NGA bug.  Could you also see whether this repros in
> flame device?  because I never saw this on Flame.  adding qawanted for it.

I've never seen what was originally described in the bug title (and what's seen in the video on Aries where the entire screen flashes quickly). That may be some sort of GFX-related bug on Aries. However, the new bug title describing a brief "dimming" when switching between two songs that have the same artwork (like when skipping tracks on the same album) definitely *IS* a bug and is easily reproducible on Flame and Aries. My patch in attachment 8667551 [details] [review] should fix that.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to No-Jun Park [:njpark] from comment #4)
> This is probably the NGA bug.  Could you also see whether this repros in
> flame device?  because I never saw this on Flame.  adding qawanted for it.

This is reproducible on Flame. Album art dims once entering song playing screen.

Device: Flame 2.5
BuildID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 9

[Jim Porter (:squib)]

Comment on attachment 8667551 [details] [review]
[gaia] justindarc:bug1209661 > mozilla-b2g:master

rs=me. Seems sane.

Comment 10

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/fc198ed60573dba66a7576ee9f99a52fed7778c2

Comment 11

[Justin D'Arcangelo [:justindarc]]

Re-opening this because I am seeing it again. Most likely because a Gecko CSS transition issue was recently fixed.

Comment 12

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #11)
> Re-opening this because I am seeing it again. Most likely because a Gecko
> CSS transition issue was recently fixed.

Either I was using the wrong revision of the app or a Gecko regression was fixed, but I am no longer able to reproduce this. Closing again. If it happens again, I'll re-open.