1209695 - fold mochitest test test_bug413909.html into xpcshell test test_cert_overrides.js

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

test_bug413909.html doesn't need to be a mochitest. It can be folded into the xpcshell test test_cert_overrides.js fairly easily.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: MozReview Request: bug 1209695 - fold mochitest test_bug413909.html into xpcshell test_cert_overrides.js r?mgoodwin

bug 1209695 - fold mochitest test_bug413909.html into xpcshell test_cert_overrides.js r?mgoodwin

test_bug413909.html doesn't need to be a mochitest. Furthermore,
test_cert_overrides.js tests a lot of the same functionality.
This just moves the unique parts from the old test to a new home
in the xpcshell test (to be specific, some IDN handling and that
"port" -1 is the same as port 443).

Comment 2

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8672011 [details]
MozReview Request: bug 1209695 - fold mochitest test_bug413909.html into xpcshell test_cert_overrides.js r?mgoodwin

https://reviewboard.mozilla.org/r/21665/#review19627

r+

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks!
Here's what try looks like: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ca5e8268cf3
I've seen the OS X build failures on other unrelated pushes to try, so I'm going to optimistically assume they're unrelated.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5b1921c0d6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b5b1921c0d6