Closed
Bug 1209702
Opened 9 years ago
Closed 9 years ago
Remove vestigial references to ThreadActor forceCompletion
Categories
(DevTools :: Debugger, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
Details
Attachments
(1 file)
|
2.13 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
This looks like it was decided to not be implemented in bug 736733, yet the ThreadActor has an option to call it with an error packet.
|
Assignee | |
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2469413f3c5b
Attachment #8667523 -
Flags: review?(nfitzgerald)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8667523 [details] [diff] [review] 1209702-forcecompletion.patch Review of attachment 8667523 [details] [diff] [review]: ----------------------------------------------------------------- https://www.youtube.com/watch?v=-ZxHAZChcYU
Attachment #8667523 -
Flags: review?(nfitzgerald) → review+
Backed out in https://hg.mozilla.org/integration/fx-team/rev/ca03fc99560e for static build failures: https://treeherder.mozilla.org/logviewer.html#?job_id=4895578&repo=fx-team
Flags: needinfo?(jsantell)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Relanded -- failure was from another patch, not this one
Flags: needinfo?(jsantell)
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/55d38169a4ee
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•