1209718 - New Utility Tray is not screen reader friendly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Eitan Isaacson [:eeejay]]

Didn't have a chance to dig in to the entire thing, but it looks like the new utility tray does not work well with the screen reader, it always shows as partially open. I think this may be because it is clipping stuff offscreen without hiding it, and the screen reader scrolls it into view.

STR on flame:
1. Turn on screen reader.
2. Press power button to turn off screen.
3. Press power button to turn screen on again.

Result: The lockscreen shows a partially visible utility tray.
Expected: Utility tray should not be visible.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: screenshot.png

This is what I see.

Comment 2

[Marcus Cavanaugh [:mcav]]

I'll take this, should be a quick followup. Thanks for the heads-up!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] mcav:utility-tray-aria > mozilla-b2g:master

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8672157 [details] [review]
[gaia] mcav:utility-tray-aria > mozilla-b2g:master

Eitan, could you try out this patch and see if it fully addresses your problems? I'm able to verify that the tray doesn't get in the way now, but I'm not sure how to make it appear. There's existing support hooked up through "statusbarwheel" and "wheel" events to show and hide the tray, respectively, which should be unaffected by the "new" tray changes, but with various two-finger-swipes I haven't been able to activate the tray, and I'm not sure how I'm supposed to.

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8672157 [details] [review]
[gaia] mcav:utility-tray-aria > mozilla-b2g:master

Generally, this is an improvement. To use the two finger swipe, you need to have screen reader focus on the status bar item, and then do a 2 finger swipe down. As you can see from the soon-to-be-attached screenshot the utility tray opens, but it has a funny gap at the bottom. Is that intentional?

There should also be a 3 finger swipe edge gesture that is not working. But that is another issues.

Thanks for this!

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: screenshot2.png

Comment 7

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8672157 [details] [review]
[gaia] mcav:utility-tray-aria > mozilla-b2g:master

This patch:

- sets "aria-hidden" when the tray is not visible, to ensure that the screen reader doesn't see the tray when it's hidden;

- fixes "wheel" event handling, such that a "wheel" event emitted from either the statusbar or the tray causes the tray to toggle visibility accordingly;

- adds marionette tests for proper "wheel" behavior.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8672157 [details] [review]
[gaia] mcav:utility-tray-aria > mozilla-b2g:master

Looking good!

Comment 9

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8672157 [details] [review]
[gaia] mcav:utility-tray-aria > mozilla-b2g:master

It turns out I had missed a test (the "ambient indicator") which required some minor changes to the patch. Aria-hiding the full #utility-tray-motion element was too heavyhanded; the ambient indicator lived within the tray, so I moved it out underneath #utility-tray-motion and now toggle aria-hidden on #utility-tray itself. This required a couple minor test changes. I've manually verified that the screen reader still works as expected. Sorry for the churn!

Comment 10

[Marcus Cavanaugh [:mcav]]

master: https://github.com/mozilla-b2g/gaia/commit/8d0d0431c03c517ad99562e91d75d89ee5203023