Closed Bug 1209731 Opened 6 years ago Closed 6 years ago
Result::NOT _READY from Paint Background With SC if we couldn't prepare the ns Image Renderer
I noticed when debugging border-image sync decoding issues that we need to return DrawResult::NOT_READY in the border-image case if we couldn't prepare the nsImageRenderer, because that means we should try to paint again if we do a paint where we're sync decoding images. It seems to me that we should also be doing that in PaintBackgroundWithSC.
Here's the patch. Very simple, but again, I think it's best to isolate this to a separate bug in case there are regressions.
Sadly this has to get a bit more complicated, because we really have to be able to distinguish recoverable from nonrecoverable issues in PrepareImage(). At some point I'd like to rework how this whole thing works, but I think this is the cleanest things can be without some substantial refactoring.
Attachment #8670646 - Flags: review?(tnikkel)
Try looks good.
Attachment #8670646 - Flags: review?(tnikkel) → review+
Thanks for the review!
You need to log in before you can comment on or make changes to this bug.