1209731 - Return DrawResult::NOT_READY from PaintBackgroundWithSC if we couldn't prepare the nsImageRenderer

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Seth Fowler [:seth] [:s2h]]

I noticed when debugging border-image sync decoding issues that we need to return DrawResult::NOT_READY in the border-image case if we couldn't prepare the nsImageRenderer, because that means we should try to paint again if we do a paint where we're sync decoding images.

It seems to me that we should also be doing that in PaintBackgroundWithSC.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Return DrawResult::NOT_READY from PaintBackgroundWithSC if we couldn't prepare the nsImageRenderer

Here's the patch. Very simple, but again, I think it's best to isolate this to a
separate bug in case there are regressions.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: Return DrawResult::NOT_READY from PaintBackgroundWithSC if we couldn't prepare the nsImageRenderer.

Sadly this has to get a bit more complicated, because we really have to be able
to distinguish recoverable from nonrecoverable issues in PrepareImage().

At some point I'd like to rework how this whole thing works, but I think this is
the cleanest things can be without some substantial refactoring.

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ca12107d26f

Comment 4

[Seth Fowler [:seth] [:s2h]]

Try looks good.

Comment 5

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 6

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9508171549

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eb9508171549