1209785 - The playlist will restart when the next song button is pressed twice on the last song in the music app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user is listening to a playlist with the repeat playlist option turned off and they press the next song button twice on the last song the playlist will restart. if the user lets the song end naturally the playlist will not restart.

Prerequisite:
Make sure that the repeat playlist option is off.

Repro Steps:
1) Update a Aries to 20150929110451
2) Open the music app
3) Start playing a playlist
4) Go to the last song in the playlist
5) Press the next song button twice
6) Observe playlist restart

Actual:
The playlist restarts

Expected:
It is expected that the playlist does not restart when the option is off.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150929110451
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 10/10
See attached: video clip(https://youtu.be/qPmSjc2UsHU), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150929030205
Gaia: f345f6a015709beeb2ca3955cab077fcaa959d3b
Gecko: acdb22976ff86539dc10413c5f366e1fb429a680
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result.
The playlist restarts
-----------------------------
The NGA music app is not in 2.2, the playlist does not restart when the next song button is pressed twice.

Comment 2

[Justin D'Arcangelo [:justindarc]]

I know what's going on here. Taking this.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1209785 > mozilla-b2g:master

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8667652 [details] [review]
[gaia] justindarc:bug1209785 > mozilla-b2g:master

Adds the missing, but critical, "stopped" state. This also updates the lockscreen/notification controls to hide when the end of a non-repeating playlist is reached.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 8667652 [details] [review]
[gaia] justindarc:bug1209785 > mozilla-b2g:master

Cool beans! I'm glad I checked my email before fixing this, because this is what I was grumbling about on IRC.

Another case to check is what happens when you play an album with either a) only one song, or b) no album name in the metadata. I saw some weird issue on master with an "album" that fit both categories where tapping it from the tiles view resulted in the song playing, and then continuing on  to the first album alphabetically.

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to Jim Porter (:squib) from comment #5)
> Comment on attachment 8667652 [details] [review]
> [gaia] justindarc:bug1209785 > mozilla-b2g:master
> 
> Cool beans! I'm glad I checked my email before fixing this, because this is
> what I was grumbling about on IRC.
> 
> Another case to check is what happens when you play an album with either a)
> only one song, or b) no album name in the metadata. I saw some weird issue
> on master with an "album" that fit both categories where tapping it from the
> tiles view resulted in the song playing, and then continuing on  to the
> first album alphabetically.

I believe that's another issue altogether and I've seen that happen as well. I'll try and narrow in on the STR/criteria that's causing it and open a new bug for it (I suspect it has something to do with our API's URL scheme).

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/5321c3df9bfeaae67c73fd3d3998c807a292f5be

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

This issue is verified as fixed in Flame 2.5 and Aries 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151001114357
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 2c1fb007137dcb68b1862a79553b53f1a34c99c3
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.5 [Full Flash]
BuildID: 20151001030229
Gaia: bd8ff00faac97ad6a2df5a6217910b8d295d56a3
Gecko: 096c0f407f8ba3ef7cfe4e0b831761993cac38b1
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.00

Result:
the music app returns to the playlist screen when skipping to the next song.